From: Hannes Reinecke <hare@suse.de>
To: Junichi Nomura <j-nomura@ce.jp.nec.com>
Cc: "dm-devel@redhat.com" <dm-devel@redhat.com>,
Mike Snitzer <snitzer@redhat.com>,
Alasdair Kergon <agk@redhat.com>
Subject: Re: [PATCH 4/8] dm mpath: remove process_queued_ios()
Date: Wed, 05 Mar 2014 09:59:32 +0100 [thread overview]
Message-ID: <5316E774.8060600@suse.de> (raw)
In-Reply-To: <11AF7C027C4C02408624617A49860784010DC73B@BPXM12GP.gisp.nec.co.jp>
On 03/03/2014 12:12 AM, Junichi Nomura wrote:
> On 02/28/14 23:33, Hannes Reinecke wrote:
>> @@ -1214,9 +1189,12 @@ static void pg_init_done(void *data, int errors)
>>
>> if (!m->pg_init_required)
>> m->queue_io = 0;
>> -
>> - m->pg_init_delay_retry = delay_retry;
>> - queue_work(kmultipathd, &m->process_queued_ios);
>> + else if (m->current_pg) {
>> + m->pg_init_delay_retry = delay_retry;
>> + if (__pg_init_all_paths(m))
>> + goto out;
>> + m->queue_io = 0;
>> + }
>
> Hi Hannes,
>
> If m->pg_init_required && !m->current_pg,
> doesn't m->queue_io remain 1 while nobody kicks pg_init?
>
> That's why I suggested this:
>
> if (m->pg_init_required) {
> m->pg_init_delay_retry = delay_retry;
> if (__pg_init_all_paths(m))
> goto out;
> }
> m->queue_io = 0;
>
Yeah, sorry. You are right.
Mike, can you fix it up or do you need an additional round of patches?
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2014-03-05 8:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 14:33 [PATCHv9 0/8] dm-multipath: push back requests instead of queueing Hannes Reinecke
2014-02-28 14:33 ` [PATCH 1/8] dm mpath: do not call pg_init when it is already running Hannes Reinecke
2014-02-28 14:33 ` [PATCH 2/8] dm table: add dm_table_run_md_queue_async Hannes Reinecke
2014-02-28 14:33 ` [PATCH 3/8] dm mpath: push back requests instead of queueing Hannes Reinecke
2014-02-28 14:33 ` [PATCH 4/8] dm mpath: remove process_queued_ios() Hannes Reinecke
2014-03-02 23:12 ` Junichi Nomura
2014-03-05 8:59 ` Hannes Reinecke [this message]
2014-03-05 14:24 ` Mike Snitzer
2014-02-28 14:33 ` [PATCH 5/8] dm mpath: reduce memory pressure when requeuing Hannes Reinecke
2014-02-28 14:33 ` [PATCH 6/8] dm mpath: remove map_io() Hannes Reinecke
2014-02-28 14:33 ` [PATCH 7/8] dm mpath: remove extra nesting in map function Hannes Reinecke
2014-02-28 14:33 ` [PATCH 8/8] dm-mpath: do not activate failed paths Hannes Reinecke
2014-03-12 21:46 ` [PATCHv9 0/8] dm-multipath: push back requests instead of queueing Mike Snitzer
2014-03-13 6:46 ` Hannes Reinecke
-- strict thread matches above, loose matches on Subject: below --
2014-02-27 7:30 [PATCHv8 " Hannes Reinecke
2014-02-27 7:30 ` [PATCH 4/8] dm mpath: remove process_queued_ios() Hannes Reinecke
2014-02-28 9:05 ` Junichi Nomura
2014-02-28 9:37 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5316E774.8060600@suse.de \
--to=hare@suse.de \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=j-nomura@ce.jp.nec.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.