From: Edward Cree <ecree@solarflare.com>
To: David Miller <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <sshah@solarflare.com>
Subject: Re: [PATCH net-next] sfc: Use ether_addr_copy and eth_broadcast_addr
Date: Wed, 5 Mar 2014 11:48:05 +0000 [thread overview]
Message-ID: <53170EF5.1030809@solarflare.com> (raw)
In-Reply-To: <20140304.153653.263004778768283059.davem@davemloft.net>
On 04/03/14 20:36, David Miller wrote:
>> diff --git a/drivers/net/ethernet/sfc/ef10.c b/drivers/net/ethernet/sfc/ef10.c
>> index 3b39798..de0c815 100644
>> --- a/drivers/net/ethernet/sfc/ef10.c
>> +++ b/drivers/net/ethernet/sfc/ef10.c
>> @@ -162,8 +162,8 @@ static int efx_ef10_get_mac_address(struct efx_nic *efx, u8 *mac_address)
>> if (outlen < MC_CMD_GET_MAC_ADDRESSES_OUT_LEN)
>> return -EIO;
>>
>> - memcpy(mac_address,
>> - MCDI_PTR(outbuf, GET_MAC_ADDRESSES_OUT_MAC_ADDR_BASE), ETH_ALEN);
>> + ether_addr_copy(mac_address,
>> + MCDI_PTR(outbuf, GET_MAC_ADDRESSES_OUT_MAC_ADDR_BASE));
> This is not indented correctly, the original code was.
Oops, yes.
After fixing that, checkpatch also complains about a couple of long
lines (mcdi.c:1207-8). Am I right in thinking that it's being
overzealous and is best ignored in this case? Alternatively I suppose
the expression starting 'port_num ? ' could go in a local variable;
would that be clearer?
next prev parent reply other threads:[~2014-03-05 11:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 20:11 [PATCH net-next] sfc: Use ether_addr_copy and eth_broadcast_addr Edward Cree
2014-03-04 20:36 ` David Miller
2014-03-05 11:48 ` Edward Cree [this message]
2014-03-05 17:10 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53170EF5.1030809@solarflare.com \
--to=ecree@solarflare.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sshah@solarflare.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.