From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36148)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WLDHL-00077j-8i
	for qemu-devel@nongnu.org; Wed, 05 Mar 2014 09:58:45 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WLDHF-0000OT-AE
	for qemu-devel@nongnu.org; Wed, 05 Mar 2014 09:58:39 -0500
Message-ID: <531735C3.3010203@redhat.com>
Date: Wed, 05 Mar 2014 15:33:39 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <49b80c368134449bb2b9093204aef6b6@BL2PR03MB210.namprd03.prod.outlook.com>
	<53170DFB.5050005@ozlabs.ru> <53172815.50806@redhat.com>
	<20140305134011.GH1993@redhat.com> <531730D8.6010607@redhat.com>
	<20140305142134.GI1993@redhat.com>
In-Reply-To: <20140305142134.GI1993@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] QEMU: PCI bus name on PowerPC platforms
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: "Hong-Hua.Yin@freescale.com" <Hong-Hua.Yin@freescale.com>, Alexey Kardashevskiy <aik@ozlabs.ru>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Li Zhang <zhlcindy@linux.vnet.ibm.com>, "agraf@suse.de" <agraf@suse.de>, "qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>, "david@gibson.dropbear.id.au" <david@gibson.dropbear.id.au>

Il 05/03/2014 15:21, Daniel P. Berrange ha scritto:
>> alpha/typhoon.c:    b = pci_register_bus(dev, "pci",
>> mips/gt64xxx_pci.c:     phb->bus = pci_register_bus(dev, "pci",
>> pci-host/apb.c:    phb->bus = pci_register_bus(DEVICE(phb), "pci",
>> pci-host/bonito.c:    phb->bus = pci_register_bus(DEVICE(dev), "pci",
>> sh4/sh_pci.c:    phb->bus = pci_register_bus(DEVICE(dev), "pci",
>> pci-host/versatile.c:    pci_bus_new_inplace(&s->pci_bus, sizeof(s->pci_bus), DEVICE(obj), "pci",
>>
>> plus pseries which has its own rules because it supports multiple PCI
>> host bridges, but probably can also be changed from "pci" to NULL.
>
> I'm not sure I understand the effect of changing 'pci' to NULL in this
> code, from libvirt's POV. Would using NULL mean we can rely on using
> "pci.0" as the default PCI bus name or not ?

Yes.  But the next bus that the user creates (e.g. from a PCI bridge 
without an "id") would be "pci.1" instead of having a duplicate 
"pci.0").  Needs a bit more testing of course.

Paolo