Re: [PATCH v2 2/2] Add a "make rpmball" target

[Don Slutz <dslutz@verizon.com>]

On 03/05/14 05:10, George Dunlap wrote:
> On 03/04/2014 08:35 PM, Don Slutz wrote:
>> On 03/04/14 15:23, George Dunlap wrote:
>>> mkdir -p rpm/{BUILD,RPMS,SOURCES,SPECS,SRPMS}
>>
>> That does not work, but:
>>
>>
>> mkdir -p rpm/{BUILD,RPMS,SOURCES,SPEC,SRPMS}
>>
>> does (SPECS is not what you want.)
>
> I'm a bit confused now; your colleague said:
>
> --- Begin Quote ---
>
> s/SPEC/SPECS/ in the above two lines (per the rpm.org site).
> It also fixes Don's problem.
>
> --- End Quote ---
>
> Which sounds like the opposite. :-)
>
> The command I sent you was copied from a CentOS wiki -- was the problem perhaps that the "cat" command below the mkdir was still using "SPEC" instead of "SPECS" (and thus failing there, rather than in the rpmbuild)?
>

Yes.

> Is your version of rpmbuild happy with just the one directory named "SPECS", or would it be better to make all the directories?
>
> I don't have a Centos 5.x system to test it on.
>
> Alternately, we could accept this patch as-is, and then you could post a follow-up fixing it on your system.
>

This patch on top of yours works for me on CentOS 5.10:


diff --git a/tools/misc/mkrpm b/tools/misc/mkrpm
index 88cf13e..fb47b6d 100644
--- a/tools/misc/mkrpm
+++ b/tools/misc/mkrpm
@@ -28,8 +28,8 @@ cd dist
  rm -rf rpm

  # Fill in the rpm boilerplate
-mkdir -p rpm/SPEC
-cat >rpm/SPEC/xen.spec <<EOF
+mkdir -p rpm/{BUILD,RPMS,SOURCES,SPECS,SRPMS}
+cat >rpm/SPECS/xen.spec <<EOF
  Summary: Xen development build, version $version
  Name: xen
  Version: $version
@@ -69,7 +69,7 @@ rm -rf \$RPM_BUILD_ROOT
  EOF

  # Package it up
-rpmbuild --define "_xenroot $xenroot" --define "_topdir $PWD/rpm" -bb rpm/SPEC/xen.spec
+rpmbuild --define "_xenroot $xenroot" --define "_topdir $PWD/rpm" -bb rpm/SPECS/xen.spec

  # Tidy up after ourselves
  mv rpm/RPMS/*/*.rpm .


    -Don Slutz

>  -George
>