From: Max Reitz <mreitz@redhat.com>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 01/10] qdict: Add qdict_join()
Date: Wed, 05 Mar 2014 21:13:32 +0100 [thread overview]
Message-ID: <5317856C.40105@redhat.com> (raw)
In-Reply-To: <53175655.6040203@redhat.com>
On 05.03.2014 17:52, Eric Blake wrote:
> On 03/03/2014 08:28 AM, Max Reitz wrote:
>> This function joins two QDicts by absorbing one into the other.
>>
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>> ---
>> include/qapi/qmp/qdict.h | 3 +++
>> qobject/qdict.c | 32 ++++++++++++++++++++++++++++++++
>> 2 files changed, 35 insertions(+)
>>
> Reviewed-by: Eric Blake <eblake@redhat.com>
>
> However, I think you should expand the testsuite to cover this addition
> (can be a followup)
I keep forgetting the tests for QDict... Yes, I'll include it in v2.
Thanks,
Max
next prev parent reply other threads:[~2014-03-05 20:13 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-03 15:28 [Qemu-devel] [PATCH 00/10] block/json: Add JSON protocol driver Max Reitz
2014-03-03 15:28 ` [Qemu-devel] [PATCH 01/10] qdict: Add qdict_join() Max Reitz
2014-03-05 15:55 ` Benoît Canet
2014-03-05 16:01 ` Kevin Wolf
2014-03-05 16:06 ` Benoît Canet
2014-03-05 16:52 ` Eric Blake
2014-03-05 20:13 ` Max Reitz [this message]
2014-03-03 15:28 ` [Qemu-devel] [PATCH 02/10] block/json: Add JSON protocol driver Max Reitz
2014-03-05 16:04 ` Benoît Canet
2014-03-05 19:58 ` Max Reitz
2014-03-05 20:20 ` Benoît Canet
2014-03-05 20:21 ` Max Reitz
2014-03-05 21:18 ` Benoît Canet
2014-03-03 15:28 ` [Qemu-devel] [PATCH 03/10] block/json: Add functions for cache control Max Reitz
2014-03-05 16:07 ` Benoît Canet
2014-03-03 15:28 ` [Qemu-devel] [PATCH 04/10] block/json: Add functions for writing zeroes etc Max Reitz
2014-03-05 16:09 ` Benoît Canet
2014-03-05 20:03 ` Max Reitz
2014-03-03 15:28 ` [Qemu-devel] [PATCH 05/10] block/json: Add bdrv_co_get_block_status() Max Reitz
2014-03-05 16:11 ` Benoît Canet
2014-03-05 20:10 ` Max Reitz
2014-03-05 20:41 ` Benoît Canet
2014-03-05 20:44 ` Max Reitz
2014-03-05 23:22 ` Benoît Canet
2014-03-06 20:01 ` Max Reitz
2014-03-03 15:28 ` [Qemu-devel] [PATCH 06/10] block/json: Add ioctl etc Max Reitz
2014-03-05 16:14 ` Benoît Canet
2014-03-03 15:28 ` [Qemu-devel] [PATCH 07/10] block/json: Add bdrv_get_specific_info() Max Reitz
2014-03-05 16:15 ` Benoît Canet
2014-03-03 15:28 ` [Qemu-devel] [PATCH 08/10] block/raw_bsd: " Max Reitz
2014-03-05 16:16 ` Benoît Canet
2014-03-03 15:28 ` [Qemu-devel] [PATCH 09/10] block/qapi: Ignore filters on top for format name Max Reitz
2014-03-05 16:20 ` Benoît Canet
2014-03-05 20:11 ` Max Reitz
2014-03-03 15:28 ` [Qemu-devel] [PATCH 10/10] iotests: Add test for the JSON protocol Max Reitz
2014-03-05 17:27 ` Eric Blake
2014-03-05 20:15 ` Max Reitz
2014-03-05 20:27 ` Eric Blake
2014-03-05 16:26 ` [Qemu-devel] [PATCH 00/10] block/json: Add JSON protocol driver Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5317856C.40105@redhat.com \
--to=mreitz@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.