From: Eric Blake <eblake@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, aliguori@amazon.com, qemu-trivial@nongnu.org,
coreyb@linux.vnet.ibm.com, mjt@tls.msk.ru, mreitz@redhat.com,
stefanha@redhat.com, lcapitulino@redhat.com, pbonzini@redhat.com,
lersek@redhat.com, afaerber@suse.de
Subject: Re: [Qemu-trivial] [PATCH v3 2/2] vl: convert -m to QemuOpts
Date: Wed, 05 Mar 2014 13:33:43 -0700 [thread overview]
Message-ID: <53178A27.1050103@redhat.com> (raw)
In-Reply-To: <1394035840-1584-3-git-send-email-imammedo@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 982 bytes --]
On 03/05/2014 09:10 AM, Igor Mammedov wrote:
> Adds option to -m
> "size" - startup memory amount
>
> For compatibility with legacy CLI if suffix-less number is passed,
> it assumes amount in Mb.
>
> Otherwise user is free to use suffixed number using suffixes b,k/K,M,G
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> v2:
> - suggested by Andreas Färber <afaerber@suse.de>
> * s/fprintf/error_report/
> * rename 'mem' option to 'size'
> - fix conflict with missing numa QemuOpts
Given the amount of rework in v2, it may have been smarter to drop my
R-b tag. But beyond Andreas' findings of missing s/mem/size/ instances,
I'm not spotting any problems, so if that's the only fix you make for
v4, you can keep my R-b.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Eric Blake <eblake@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, aliguori@amazon.com, qemu-trivial@nongnu.org,
coreyb@linux.vnet.ibm.com, mjt@tls.msk.ru, mreitz@redhat.com,
stefanha@redhat.com, lcapitulino@redhat.com, pbonzini@redhat.com,
akong@redhat.com, lersek@redhat.com, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH v3 2/2] vl: convert -m to QemuOpts
Date: Wed, 05 Mar 2014 13:33:43 -0700 [thread overview]
Message-ID: <53178A27.1050103@redhat.com> (raw)
In-Reply-To: <1394035840-1584-3-git-send-email-imammedo@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 982 bytes --]
On 03/05/2014 09:10 AM, Igor Mammedov wrote:
> Adds option to -m
> "size" - startup memory amount
>
> For compatibility with legacy CLI if suffix-less number is passed,
> it assumes amount in Mb.
>
> Otherwise user is free to use suffixed number using suffixes b,k/K,M,G
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> v2:
> - suggested by Andreas Färber <afaerber@suse.de>
> * s/fprintf/error_report/
> * rename 'mem' option to 'size'
> - fix conflict with missing numa QemuOpts
Given the amount of rework in v2, it may have been smarter to drop my
R-b tag. But beyond Andreas' findings of missing s/mem/size/ instances,
I'm not spotting any problems, so if that's the only fix you make for
v4, you can keep my R-b.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2014-03-05 20:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 16:10 [Qemu-trivial] [PATCH v3 0/2] convert -m to QemuOpts Igor Mammedov
2014-03-05 16:10 ` [Qemu-devel] " Igor Mammedov
2014-03-05 16:10 ` [Qemu-trivial] [PATCH v3 1/2] qemu-option: introduce qemu_find_opts_singleton Igor Mammedov
2014-03-05 16:10 ` [Qemu-devel] " Igor Mammedov
2014-03-05 16:10 ` [Qemu-trivial] [PATCH v3 2/2] vl: convert -m to QemuOpts Igor Mammedov
2014-03-05 16:10 ` [Qemu-devel] " Igor Mammedov
2014-03-05 17:04 ` [Qemu-trivial] " Andreas Färber
2014-03-05 17:04 ` [Qemu-devel] " Andreas Färber
2014-03-06 9:37 ` [Qemu-trivial] " Igor Mammedov
2014-03-06 9:37 ` Igor Mammedov
2014-03-05 20:33 ` Eric Blake [this message]
2014-03-05 20:33 ` Eric Blake
2014-03-06 9:37 ` [Qemu-trivial] " Igor Mammedov
2014-03-06 9:37 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53178A27.1050103@redhat.com \
--to=eblake@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@amazon.com \
--cc=coreyb@linux.vnet.ibm.com \
--cc=imammedo@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=lersek@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.