On 03/05/2014 09:10 AM, Igor Mammedov wrote:
> Adds option to -m
>  "size" - startup memory amount
> 
> For compatibility with legacy CLI if suffix-less number is passed,
> it assumes amount in Mb.
> 
> Otherwise user is free to use suffixed number using suffixes b,k/K,M,G
> 
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> v2:
>  - suggested by Andreas Färber <afaerber@suse.de>
>     * s/fprintf/error_report/
>     * rename 'mem' option to 'size'
>  - fix conflict with missing numa QemuOpts

Given the amount of rework in v2, it may have been smarter to drop my
R-b tag.  But beyond Andreas' findings of missing s/mem/size/ instances,
I'm not spotting any problems, so if that's the only fix you make for
v4, you can keep my R-b.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org