Re: [Qemu-devel] [PATCH] qjson.h: Remove GCC_FMT_ATTR markup from qobject_from_jsonv() declaration

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1091 bytes --]

On 03/05/2014 02:02 PM, Stefan Weil wrote:
> Commit aa830cdc28edb69c1fe81c8fd9471ab288ad0926 removed that attribute
> from qobject_from_json. Now gcc suggests to add it again when compiler
> flag -Wmissing-format-attribute is used:
> 
> qobject/qjson.c: In function ‘qobject_from_json’:
> qobject/qjson.c:53:5: error:
>  function might be possible candidate for ‘gnu_printf’ format attribute
>  [-Werror=suggest-attribute=format]
> 
> Fix this by removing the flag from qobject_from_jsonv, too.

NAK.

qobject_from_jsonv needs the attribute.

Maybe this is a better approach (untested):

diff --git i/qobject/qjson.c w/qobject/qjson.c
index 6cf2511..f9616f8 100644
--- i/qobject/qjson.c
+++ w/qobject/qjson.c
@@ -50,7 +50,7 @@ QObject *qobject_from_jsonv(const char *string,
va_list *ap)

 QObject *qobject_from_json(const char *string)
 {
-    return qobject_from_jsonv(string, NULL);
+    return qobject_from_jsonf("%s", string);
 }

 /*

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]