From: Shuah Khan <shuah.kh@samsung.com>
To: Joe Perches <joe@perches.com>
Cc: lgirdwood@gmail.com, broonie@kernel.org,
gregkh@linuxfoundation.org, stable@vger.kernel.org,
linux-kernel@vger.kernel.org, shuahkhan@gmail.com,
Mark Brown <broonie@linaro.org>,
Shuah Khan <shuah.kh@samsung.com>,
"shuahkhan@gmail.com" <shuahkhan@gmail.com>
Subject: Re: [PATCH 3.13] regulator: core: Change dummy supplies error message to a warning
Date: Wed, 05 Mar 2014 15:29:02 -0700 [thread overview]
Message-ID: <5317A52E.4@samsung.com> (raw)
In-Reply-To: <1394056859.12070.23.camel@joe-AO722>
On 03/05/2014 03:00 PM, Joe Perches wrote:
> On Wed, 2014-03-05 at 14:29 -0700, Shuah Khan wrote:
>> Change "dummy supplies not allowed" error message to warning instead,
>> as this is a just warning message with no change to the behavior.
> []
>> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> []
>> @@ -1359,7 +1359,7 @@ static struct regulator *_regulator_get(struct device *dev, const char *id,
>> rdev = dummy_regulator_rdev;
>> goto found;
>> } else {
>> - dev_err(dev, "dummy supplies not allowed\n");
>> + dev_warn(dev, "dummy supplies not allowed\n");
>
> What does this mean anyway?
>
> Would it be better to emit the calling function too with
> %pf, __builtin_return_address(0)?
>
Maybe. In that case, that change has to first go into the mainline. This
is a back port of an upstream commit to get rid of a regression in error
messages.
-- Shuah
--
Shuah Khan
Senior Linux Kernel Developer - Open Source Group
Samsung Research America(Silicon Valley)
shuah.kh@samsung.com | (970) 672-0658
next prev parent reply other threads:[~2014-03-05 22:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 21:29 [PATCH 3.13] regulator: core: Change dummy supplies error message to a warning Shuah Khan
2014-03-05 22:00 ` Joe Perches
2014-03-05 22:29 ` Shuah Khan [this message]
2014-03-19 23:58 ` Greg KH
2014-03-20 10:02 ` Mark Brown
2014-03-20 21:16 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5317A52E.4@samsung.com \
--to=shuah.kh@samsung.com \
--cc=broonie@kernel.org \
--cc=broonie@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shuahkhan@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.