From: Minkyu Kang <mk7.kang@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] samsung: misc: check_keys(), key_pressed() - remove type static.
Date: Thu, 06 Mar 2014 15:51:18 +0900 [thread overview]
Message-ID: <53181AE6.6070207@samsung.com> (raw)
In-Reply-To: <e80d29b1808641e6bc40a589eed49a45e60a4538.1393597480.git.p.marczak@samsung.com>
On 28/02/14 23:30, Przemyslaw Marczak wrote:
> This patch removes type "static" from those functions declaration.
> Now it can be used outside.
outside where?
I think there's no reason to make them to non-static function.
If you want to use it at outside then please send the patch together.
>
> Change-Id: I2244ca3568b73251401e5102f26cc113ea69c1a4
> Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com>
> cc: Minkyu Kang <mk7.kang@samsung.com>
> ---
> board/samsung/common/misc.c | 5 ++---
> include/samsung/misc.h | 4 ++++
> 2 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/board/samsung/common/misc.c b/board/samsung/common/misc.c
> index eb15739..1d6f4e4 100644
> --- a/board/samsung/common/misc.c
> +++ b/board/samsung/common/misc.c
> @@ -15,7 +15,6 @@
> #include <asm/arch/cpu.h>
> #include <asm/arch/gpio.h>
> #include <asm/gpio.h>
> -#include <linux/input.h>
> #include <power/pmic.h>
> #include <mmc.h>
>
> @@ -72,7 +71,7 @@ static int power_key_pressed(u32 reg)
> return !!(status & mask);
> }
>
> -static int key_pressed(int key)
> +int key_pressed(int key)
> {
> int value;
>
> @@ -94,7 +93,7 @@ static int key_pressed(int key)
> return value;
> }
>
> -static int check_keys(void)
> +int check_keys(void)
> {
> int keys = 0;
>
> diff --git a/include/samsung/misc.h b/include/samsung/misc.h
> index ede6c15..47beb1f 100644
> --- a/include/samsung/misc.h
> +++ b/include/samsung/misc.h
> @@ -1,6 +1,8 @@
> #ifndef __SAMSUNG_MISC_COMMON_H__
> #define __SAMSUNG_MISC_COMMON_H__
>
> +#include <linux/input.h>
> +
> #ifdef CONFIG_REVISION_TAG
> u32 get_board_rev(void);
> #endif
> @@ -19,6 +21,8 @@ enum {
> };
>
> void keys_init(void);
> +int check_keys(void);
> +int key_pressed(int key);
> void check_boot_mode(void);
> #endif /* CONFIG_LCD_MENU */
>
>
Thanks,
Minkyu Kang.
next prev parent reply other threads:[~2014-03-06 6:51 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 14:30 [U-Boot] [PATCH 0/3] samsung: misc: add new lcd menu options Przemyslaw Marczak
2014-02-28 14:30 ` [U-Boot] [PATCH 1/3] samsung: misc: check_keys(), key_pressed() - remove type static Przemyslaw Marczak
2014-03-06 6:51 ` Minkyu Kang [this message]
2014-03-21 9:13 ` Przemyslaw Marczak
2014-02-28 14:30 ` [U-Boot] [PATCH 2/3] samsung: misc: add gpt restore option to lcd menu Przemyslaw Marczak
2014-02-28 14:30 ` [U-Boot] [PATCH 3/3] samsung: misc: add env default " Przemyslaw Marczak
2014-02-28 14:36 ` [U-Boot] [PATCH 0/3] samsung: misc: add new lcd menu options Przemyslaw Marczak
2014-04-02 9:41 ` [U-Boot] [PATCH v2 1/4] samsung: misc: allows using environmental macros as args in menu commands Przemyslaw Marczak
2014-04-02 9:41 ` [U-Boot] [PATCH v2 2/4] samsung: misc: add gpt restore option to lcd menu Przemyslaw Marczak
2014-04-02 9:42 ` [U-Boot] [PATCH v2 3/4] samsung: misc: add env default " Przemyslaw Marczak
2014-04-02 9:42 ` [U-Boot] [PATCH v2 4/4] samsung: misc: keys: fix gpio key debouncing by adding 50 ms delay Przemyslaw Marczak
2014-04-02 17:26 ` Gerhard Sittig
2014-04-03 7:03 ` Przemyslaw Marczak
2014-04-03 8:27 ` [U-Boot] [PATCH v3 1/4] samsung: misc: allows using environmental macros as args in menu commands Przemyslaw Marczak
2014-04-03 8:27 ` [U-Boot] [PATCH v3 2/4] samsung: misc: add gpt restore option to lcd menu Przemyslaw Marczak
2014-04-03 8:27 ` [U-Boot] [PATCH v3 3/4] samsung: misc: add env default " Przemyslaw Marczak
2014-04-03 8:27 ` [U-Boot] [PATCH v3 4/4] samsung: misc: keys: fix gpio key bouncing by adding 50 ms delay Przemyslaw Marczak
2014-04-25 10:20 ` [U-Boot] [PATCH v4 1/5] samsung: misc: allows using environmental macros as args in menu commands Przemyslaw Marczak
2014-04-25 10:20 ` [U-Boot] [PATCH v4 2/5] samsung: misc: add gpt restore option to lcd menu Przemyslaw Marczak
2014-04-25 10:20 ` [U-Boot] [PATCH v4 3/5] samsung: misc: add env default " Przemyslaw Marczak
2014-04-25 10:20 ` [U-Boot] [PATCH v4 4/5] samsung: misc: keys: fix gpio key bouncing by adding 50 ms delay Przemyslaw Marczak
2014-04-28 13:44 ` Gerhard Sittig
2014-04-28 14:03 ` Gerhard Sittig
2014-04-30 10:10 ` Przemyslaw Marczak
2014-04-25 10:20 ` [U-Boot] [PATCH v4 5/5] samsung: misc: remove download mode info screen Przemyslaw Marczak
2014-04-30 11:28 ` [U-Boot] [PATCH v5 1/5] samsung: misc: allows using environmental macros as args in menu commands Przemyslaw Marczak
2014-04-30 11:28 ` [U-Boot] [PATCH v5 2/5] samsung: misc: add gpt restore option to lcd menu Przemyslaw Marczak
2014-05-08 2:36 ` Minkyu Kang
2014-04-30 11:28 ` [U-Boot] [PATCH v5 3/5] samsung: misc: add env default " Przemyslaw Marczak
2014-05-08 2:36 ` Minkyu Kang
2014-04-30 11:28 ` [U-Boot] [PATCH v5 4/5] samsung: misc: menu: increase delay in menu main loop Przemyslaw Marczak
2014-05-05 13:35 ` Gerhard Sittig
2014-05-06 8:32 ` Przemyslaw Marczak
2014-05-08 2:36 ` Minkyu Kang
2014-04-30 11:28 ` [U-Boot] [PATCH v5 5/5] samsung: misc: remove download mode info screen Przemyslaw Marczak
2014-05-05 13:27 ` Minkyu Kang
2014-05-06 8:45 ` Przemyslaw Marczak
2014-05-07 8:07 ` Minkyu Kang
2014-05-08 2:36 ` Minkyu Kang
2014-05-08 2:36 ` [U-Boot] [PATCH v5 1/5] samsung: misc: allows using environmental macros as args in menu commands Minkyu Kang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53181AE6.6070207@samsung.com \
--to=mk7.kang@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.