All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/6] toolchain-external: fix musl external support on x86
Date: Thu, 06 Mar 2014 08:09:39 +0100	[thread overview]
Message-ID: <53181F33.4060004@mind.be> (raw)
In-Reply-To: <1394058220-5863-2-git-send-email-thomas.petazzoni@free-electrons.com>

On 05/03/14 23:23, Thomas Petazzoni wrote:
> On x86, the symbolic link ld-musl-<ARCH>.so.1 to libc.so must be
> ld-musl-i386.so.1 in all cases, but $(ARCH) in Buildroot might be
> i386, i486, i586, i686, etc. depending on the specific x86 variants
> being selected.
> 
> This commit fixes that by creating a MUSL_ARCH variable set to i386 on
> x86, and to $(ARCH) on other architectures.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

> ---
>  toolchain/toolchain-external/toolchain-external.mk | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/toolchain/toolchain-external/toolchain-external.mk b/toolchain/toolchain-external/toolchain-external.mk
> index 378e7b2..1b1053d 100644
> --- a/toolchain/toolchain-external/toolchain-external.mk
> +++ b/toolchain/toolchain-external/toolchain-external.mk
> @@ -447,8 +447,13 @@ endef
>  # of the dynamic library loader. We just need to create a symbolic
>  # link to libc.so with the appropriate name.
>  ifeq ($(BR2_TOOLCHAIN_EXTERNAL_MUSL),y)
> +ifeq ($(BR2_i386),y)
> +MUSL_ARCH = i386
> +else
> +MUSL_ARCH = $(ARCH)
> +endif
>  define TOOLCHAIN_EXTERNAL_MUSL_LD_LINK
> -	ln -sf libc.so $(TARGET_DIR)/lib/ld-musl-$(ARCH).so.1
> +	ln -sf libc.so $(TARGET_DIR)/lib/ld-musl-$(MUSL_ARCH).so.1
>  endef
>  TOOLCHAIN_EXTERNAL_POST_INSTALL_STAGING_HOOKS += TOOLCHAIN_EXTERNAL_MUSL_LD_LINK
>  endif
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

  reply	other threads:[~2014-03-06  7:09 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-05 22:23 [Buildroot] [PATCH 0/6] External toolchain updates Thomas Petazzoni
2014-03-05 22:23 ` [Buildroot] [PATCH 1/6] toolchain-external: fix musl external support on x86 Thomas Petazzoni
2014-03-06  7:09   ` Arnout Vandecappelle [this message]
2014-03-05 22:23 ` [Buildroot] [PATCH 2/6] toolchain-external: add publicly available musl toolchains Thomas Petazzoni
2014-03-06  7:17   ` Arnout Vandecappelle
2014-03-05 22:23 ` [Buildroot] [PATCH 3/6] toolchain-external: bump Linaro ARM toolchains Thomas Petazzoni
2014-03-05 22:23 ` [Buildroot] [PATCH 4/6] toolchain-external: remove useless info in help text of " Thomas Petazzoni
2014-03-05 22:39   ` Yann E. MORIN
2014-03-05 22:23 ` [Buildroot] [PATCH 5/6] toolchain-external: bump Linaro AArch64 toolchains Thomas Petazzoni
2014-03-05 22:23 ` [Buildroot] [PATCH 6/6] toolchain-external: add Linaro ARM big endian toolchain Thomas Petazzoni
2014-03-06 22:23   ` Peter Korsgaard
2014-03-06 22:30     ` Thomas Petazzoni
2014-03-06 22:41       ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53181F33.4060004@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.