All of lore.kernel.org
 help / color / mirror / Atom feed
From: Beomho Seo <beomho.seo@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] arm: exynos: clock: Remove exynos4x12_set_mmc_clk function
Date: Thu, 06 Mar 2014 17:34:18 +0900	[thread overview]
Message-ID: <5318330A.1070207@samsung.com> (raw)
In-Reply-To: <53181D23.7060301@samsung.com>

On 03/06/2014 04:00 PM, Minkyu Kang wrote:
> On 05/03/14 10:57, Beomho Seo wrote:
>> Remove exynos4x12_set_mmc_clk.
> 
> Please describe here why you remove it.
> 

exynos4x12_set_mmc_clk function have been removed.
Because exynos4x12_clock/ exnos4_clock have same div_fsys* value.

I will describe here again when I send next version.

>>
>> Signed-off-by: Beomho Seo <beomho.seo@samsung.com>
>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>> Cc: Minkyu Kang <mk7.kang@samsung.com>
>> ---
>>  arch/arm/cpu/armv7/exynos/clock.c |   29 +----------------------------
>>  1 file changed, 1 insertion(+), 28 deletions(-)
>>
>> diff --git a/arch/arm/cpu/armv7/exynos/clock.c b/arch/arm/cpu/armv7/exynos/clock.c
>> index 1fea4d6..2c2029a 100644
>> --- a/arch/arm/cpu/armv7/exynos/clock.c
>> +++ b/arch/arm/cpu/armv7/exynos/clock.c
>> @@ -893,30 +893,6 @@ static void exynos4_set_mmc_clk(int dev_index, unsigned int div)
>>  			(div & 0xff) << ((dev_index << 4) + 8));
>>  }
>>
>> -/* exynos4x12: set the mmc clock */
>> -static void exynos4x12_set_mmc_clk(int dev_index, unsigned int div)
>> -{
>> -	struct exynos4x12_clock *clk =
>> -		(struct exynos4x12_clock *)samsung_get_base_clock();
>> -	unsigned int addr;
>> -
>> -	/*
>> -	 * CLK_DIV_FSYS1
>> -	 * MMC0_PRE_RATIO [15:8], MMC1_PRE_RATIO [31:24]
>> -	 * CLK_DIV_FSYS2
>> -	 * MMC2_PRE_RATIO [15:8], MMC3_PRE_RATIO [31:24]
>> -	 */
>> -	if (dev_index < 2) {
>> -		addr = (unsigned int)&clk->div_fsys1;
>> -	} else {
>> -		addr = (unsigned int)&clk->div_fsys2;
>> -		dev_index -= 2;
>> -	}
>> -
>> -	clrsetbits_le32(addr, 0xff << ((dev_index << 4) + 8),
>> -			(div & 0xff) << ((dev_index << 4) + 8));
>> -}
>> -
>>  /* exynos5: set the mmc clock */
>>  static void exynos5_set_mmc_clk(int dev_index, unsigned int div)
>>  {
>> @@ -1612,10 +1588,7 @@ void set_mmc_clk(int dev_index, unsigned int div)
>>  		else
>>  			exynos5_set_mmc_clk(dev_index, div);
>>  	} else {
>> -		if (proid_is_exynos4412())
>> -			exynos4x12_set_mmc_clk(dev_index, div);
>> -		else
>> -			exynos4_set_mmc_clk(dev_index, div);
>> +		exynos4_set_mmc_clk(dev_index, div);
>>  	}
>>  }
>>
> 
> Thanks,
> Minkyu Kang.
> 


-- 
Best Regards,

      reply	other threads:[~2014-03-06  8:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-05  1:57 [U-Boot] [PATCH 3/3] arm: exynos: clock: Remove exynos4x12_set_mmc_clk function Beomho Seo
2014-03-06  7:00 ` Minkyu Kang
2014-03-06  8:34   ` Beomho Seo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5318330A.1070207@samsung.com \
    --to=beomho.seo@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.