All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Disable o32 ABI for MIPS64 architectures
Date: Thu, 6 Mar 2014 09:51:03 +0000	[thread overview]
Message-ID: <53184507.7040006@imgtec.com> (raw)
In-Reply-To: <5317B2EC.4010201@mind.be>

On 03/05/2014 11:27 PM, Arnout Vandecappelle wrote:
> On 05/03/14 18:06, Vicente Olivert Riera wrote:
>> Building o32 ELF files for MIPS64 is an exotic configuration that nobody
>> should be using. If o32 is required, then is better if it's built for
>> MIPS 32-bit cores so only 32-bit instructions will be used leading to a
>> more efficient o32 usage.
>>
>> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
>> ---
>>   arch/Config.in.mips |    1 +
>>   1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/Config.in.mips b/arch/Config.in.mips
>> index d9c0c02..e2b1e60 100644
>> --- a/arch/Config.in.mips
>> +++ b/arch/Config.in.mips
>> @@ -47,6 +47,7 @@ choice
>>
>>   config BR2_MIPS_OABI32
>>   	bool "o32"
>> +	depends on !BR2_ARCH_IS_64
>>   config BR2_MIPS_NABI32
>>   	bool "n32"
>>   	depends on BR2_ARCH_IS_64
>>
>
>   Then maybe it's better to make the choice depend on BR2_ARCH_IS_64, and
> make the OABI32 symbol blind and default y on !BR2_ARCH_IS_64.

OABI32 is already the default on !BR2_ARCH_IS_64. Take a look to this 
part of the Config.in.mips:

choice
         prompt "Target ABI"
         depends on BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el
         default BR2_MIPS_OABI32 if !BR2_ARCH_IS_64
         default BR2_MIPS_NABI32 if BR2_ARCH_IS_64

>
>   Regards,
>   Arnout
>


-- 
Vincent

  reply	other threads:[~2014-03-06  9:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-05 17:06 [Buildroot] [PATCH] Disable o32 ABI for MIPS64 architectures Vicente Olivert Riera
2014-03-05 23:27 ` Arnout Vandecappelle
2014-03-06  9:51   ` Vicente Olivert Riera [this message]
2014-03-06 11:13     ` Arnout Vandecappelle
2014-03-25 17:54       ` Vicente Olivert Riera

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53184507.7040006@imgtec.com \
    --to=vincent.riera@imgtec.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.