From: Paolo Bonzini <pbonzini@redhat.com>
To: Mark Wu <wudxw@linux.vnet.ibm.com>,
qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Cc: Alexander Graf <agraf@suse.de>,
nikunj@linux.vnet.ibm.com, Anthony Liguori <aliguori@amazon.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] Add a generic vga device type for that specified by '-device'
Date: Thu, 06 Mar 2014 15:33:18 +0100 [thread overview]
Message-ID: <5318872E.5040301@redhat.com> (raw)
In-Reply-To: <53187A32.5000001@linux.vnet.ibm.com>
Il 06/03/2014 14:37, Mark Wu ha scritto:
> Thanks for your reply! I need confirm I am understanding your comments
> correctly. I think you're suggesting to traverse the pci devices and
> check if it owns the I/O port 0x3d4 to detect if the vga device
> is initialized. But it seems not be able to resolve the bug. Because
> the machine initialization code runs before the generic device
> initialization, the I/O port 0x3d4 will not be registered at the time
> machine initializes. So it can't change the return value of
> pci_vga_init. The return value is checked in ppc code, which causes the
> bug.
Right. What about looking for any PCI device with VGA class?
Paolo
next prev parent reply other threads:[~2014-03-06 14:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 12:45 [Qemu-devel] [PATCH 1/2] Add a generic vga device type for that specified by '-device' Mark Wu
2014-02-28 12:45 ` [Qemu-devel] [PATCH 2/2] Fix return value of vga initlization on ppc Mark Wu
2014-02-28 13:03 ` [Qemu-devel] [PATCH 1/2] Add a generic vga device type for that specified by '-device' Paolo Bonzini
2014-03-06 13:37 ` Mark Wu
2014-03-06 14:33 ` Paolo Bonzini [this message]
2014-03-06 14:39 ` Andreas Färber
2014-03-06 16:09 ` Paolo Bonzini
2014-03-07 9:34 ` Mark Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5318872E.5040301@redhat.com \
--to=pbonzini@redhat.com \
--cc=agraf@suse.de \
--cc=aliguori@amazon.com \
--cc=nikunj@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=wudxw@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.