From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34179)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WLZSb-0006TP-BU
	for qemu-devel@nongnu.org; Thu, 06 Mar 2014 09:39:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WLZSU-0005ku-11
	for qemu-devel@nongnu.org; Thu, 06 Mar 2014 09:39:45 -0500
Message-ID: <531888A7.2030400@suse.de>
Date: Thu, 06 Mar 2014 15:39:35 +0100
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1393591540-32435-1-git-send-email-wudxw@linux.vnet.ibm.com>	<53108919.10103@redhat.com>
	<53187A32.5000001@linux.vnet.ibm.com> <5318872E.5040301@redhat.com>
In-Reply-To: <5318872E.5040301@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 1/2] Add a generic vga device type for that
 specified by '-device'
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, Mark Wu <wudxw@linux.vnet.ibm.com>, qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Cc: Alexander Graf <agraf@suse.de>, nikunj@linux.vnet.ibm.com, Anthony Liguori <aliguori@amazon.com>

Am 06.03.2014 15:33, schrieb Paolo Bonzini:
> Il 06/03/2014 14:37, Mark Wu ha scritto:
>> Thanks for your reply!  I need confirm I am understanding your comment=
s
>> correctly.  I think you're suggesting to traverse the pci devices and
>> check if it owns the I/O port 0x3d4 to detect if the vga device
>> is initialized.    But it seems not be able to resolve the bug. Becaus=
e
>> the machine initialization code runs before the generic device
>> initialization, the I/O port 0x3d4 will not be registered at the time
>> machine initializes.  So it can't change the return value of
>> pci_vga_init.  The return value is checked in ppc code, which causes t=
he
>> bug.
>=20
> Right.  What about looking for any PCI device with VGA class?

Since VGA doesn't need to be PCI (e.g., ISA, SysBus) maybe it would be a
good idea to add a QOM interface to those devices?

Regards,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg