From: Michal Marek <mmarek@suse.cz>
To: Lucas De Marchi <lucas.demarchi@intel.com>,
linux-modules@vger.kernel.org
Subject: Re: [PATCH 4/8] testsuite: add test for '.' correctly parsed in param's value
Date: Thu, 06 Mar 2014 18:18:16 +0100 [thread overview]
Message-ID: <5318ADD8.2030108@suse.cz> (raw)
In-Reply-To: <1394114809-2737-4-git-send-email-lucas.demarchi@intel.com>
On 2014-03-06 15:06, Lucas De Marchi wrote:
> In kcmdline it's possible to have a dot in the param's value. The
> support for this was added in 66f3228 ("libkmod: Add support for '.' in
> module parameter on kcmdline") and is needed to correctly support some
> modules that depend on it.
The tests look OK. I tried to revert my fix and the test failed.
> This test was added in order to make sure the commit aa87854
> ("libkmod-config: Only match dot before '=' in /proc/cmdline") didn't
> break it. Although that commit message says it's allowing to match a
> dot before '=' it's actually enforcing the first part of the string to
> be always in the format "<module-name>.param". Dots after '=' are still
> correctly allowed.
Yeah, the wording was not really clear.
Thanks,
Michal
next prev parent reply other threads:[~2014-03-06 17:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-06 14:06 [PATCH 1/8] testsuite: add test for kcmdline params with no value Lucas De Marchi
2014-03-06 14:06 ` [PATCH 2/8] testsuite: give a more suitable description to test Lucas De Marchi
2014-03-06 14:06 ` [PATCH 3/8] testsuite: add test to ignore unrelated strings in kcmdline Lucas De Marchi
2014-03-06 14:06 ` [PATCH 4/8] testsuite: add test for '.' correctly parsed in param's value Lucas De Marchi
2014-03-06 17:18 ` Michal Marek [this message]
2014-03-06 14:06 ` [PATCH 5/8] build-sys: add small redirecting Makefiles Lucas De Marchi
2014-03-06 14:06 ` [PATCH 6/8] build-sys: Do not require xsltproc for installation of man pages Lucas De Marchi
2014-03-06 17:19 ` Michal Marek
2014-03-06 14:06 ` [PATCH 7/8] man: clarify the support to modules.dep file Lucas De Marchi
2014-03-06 14:06 ` [PATCH 8/8] man: use systemd as example instead of udev Lucas De Marchi
2014-03-06 17:22 ` Michal Marek
2014-03-06 21:47 ` Lucas De Marchi
2014-03-07 2:07 ` Lucas De Marchi
2014-03-07 9:17 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5318ADD8.2030108@suse.cz \
--to=mmarek@suse.cz \
--cc=linux-modules@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.