From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39465)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WLcxw-0002Dh-1O
	for qemu-devel@nongnu.org; Thu, 06 Mar 2014 13:24:25 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WLcxq-0004IV-1t
	for qemu-devel@nongnu.org; Thu, 06 Mar 2014 13:24:19 -0500
Message-ID: <5318BD4B.1030304@suse.de>
Date: Thu, 06 Mar 2014 19:24:11 +0100
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1386087086-3691-1-git-send-email-mst@redhat.com>
	<1386087086-3691-24-git-send-email-mst@redhat.com>
In-Reply-To: <1386087086-3691-24-git-send-email-mst@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 23/23] savevm: fix potential segfault on
 invalid state
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-stable@nongnu.org

Am 03.12.2013 17:29, schrieb Michael S. Tsirkin:
> savevm will segfault if version_id < vmsd->minimum_version_id &&
> version_id >=3D vmsd->minimum_version_id_old
>=20
> This calls through a NULL pointer.  This is a bug (should
> exit not crash).
>=20
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

Reviewed-by: Andreas F=E4rber <afaerber@suse.de>

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg