[Qemu-trivial] [PATCH v4 0/2] convert -m to QemuOpts

[Qemu-trivial] [PATCH v4 0/2] convert -m to QemuOpts

[Igor Mammedov]

changes since v3:
 - fix not completed option renaming s/mem/size/

changes since v2 suggested by Andreas Färber:
 - s/fprintf/error_report/
 - rename 'mem' option to 'size'
 - CCing to qemu-trivial

changes since v1:
 - check for overflow
 - check for empty mem="" case
 - reshuffle code to avoid conflicts with another series on list
 - some style/typo fixes

changes since RFC:
 - resolved conflict with error_abort change
   in qemu_get_machine_opts()

Igor Mammedov (1):
  vl: convert -m to QemuOpts

Paolo Bonzini (1):
  qemu-option: introduce qemu_find_opts_singleton

 include/qemu/config-file.h |    2 +
 qemu-options.hx            |    9 +++--
 util/qemu-config.c         |   14 +++++++
 vl.c                       |   82 +++++++++++++++++++++++++++++++-------------
 4 files changed, 80 insertions(+), 27 deletions(-)

[Qemu-devel] [PATCH v4 0/2] convert -m to QemuOpts

[Igor Mammedov]

changes since v3:
 - fix not completed option renaming s/mem/size/

changes since v2 suggested by Andreas Färber:
 - s/fprintf/error_report/
 - rename 'mem' option to 'size'
 - CCing to qemu-trivial

changes since v1:
 - check for overflow
 - check for empty mem="" case
 - reshuffle code to avoid conflicts with another series on list
 - some style/typo fixes

changes since RFC:
 - resolved conflict with error_abort change
   in qemu_get_machine_opts()

Igor Mammedov (1):
  vl: convert -m to QemuOpts

Paolo Bonzini (1):
  qemu-option: introduce qemu_find_opts_singleton

 include/qemu/config-file.h |    2 +
 qemu-options.hx            |    9 +++--
 util/qemu-config.c         |   14 +++++++
 vl.c                       |   82 +++++++++++++++++++++++++++++++-------------
 4 files changed, 80 insertions(+), 27 deletions(-)

[Qemu-trivial] [PATCH v4 1/2] qemu-option: introduce qemu_find_opts_singleton

[Igor Mammedov]

From: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Andreas Färber <afaerber@suse.de>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
 include/qemu/config-file.h |    2 ++
 util/qemu-config.c         |   14 ++++++++++++++
 vl.c                       |   11 +----------
 3 files changed, 17 insertions(+), 10 deletions(-)

diff --git a/include/qemu/config-file.h b/include/qemu/config-file.h
index dbd97c4..d4ba20e 100644
--- a/include/qemu/config-file.h
+++ b/include/qemu/config-file.h
@@ -8,6 +8,8 @@
 
 QemuOptsList *qemu_find_opts(const char *group);
 QemuOptsList *qemu_find_opts_err(const char *group, Error **errp);
+QemuOpts *qemu_find_opts_singleton(const char *group);
+
 void qemu_add_opts(QemuOptsList *list);
 void qemu_add_drive_opts(QemuOptsList *list);
 int qemu_set_option(const char *str);
diff --git a/util/qemu-config.c b/util/qemu-config.c
index f610101..60051df 100644
--- a/util/qemu-config.c
+++ b/util/qemu-config.c
@@ -39,6 +39,20 @@ QemuOptsList *qemu_find_opts(const char *group)
     return ret;
 }
 
+QemuOpts *qemu_find_opts_singleton(const char *group)
+{
+    QemuOptsList *list;
+    QemuOpts *opts;
+
+    list = qemu_find_opts(group);
+    assert(list);
+    opts = qemu_opts_find(list, NULL);
+    if (!opts) {
+        opts = qemu_opts_create(list, NULL, 0, &error_abort);
+    }
+    return opts;
+}
+
 static CommandLineParameterInfoList *query_option_descs(const QemuOptDesc *desc)
 {
     CommandLineParameterInfoList *param_list = NULL, *entry;
diff --git a/vl.c b/vl.c
index 685a7a9..7eb3b73 100644
--- a/vl.c
+++ b/vl.c
@@ -482,16 +482,7 @@ static QemuOptsList qemu_msg_opts = {
  */
 QemuOpts *qemu_get_machine_opts(void)
 {
-    QemuOptsList *list;
-    QemuOpts *opts;
-
-    list = qemu_find_opts("machine");
-    assert(list);
-    opts = qemu_opts_find(list, NULL);
-    if (!opts) {
-        opts = qemu_opts_create(list, NULL, 0, &error_abort);
-    }
-    return opts;
+    return qemu_find_opts_singleton("machine");
 }
 
 const char *qemu_get_vm_name(void)
-- 
1.7.1

[Qemu-devel] [PATCH v4 1/2] qemu-option: introduce qemu_find_opts_singleton

[Igor Mammedov]

From: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Andreas Färber <afaerber@suse.de>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
 include/qemu/config-file.h |    2 ++
 util/qemu-config.c         |   14 ++++++++++++++
 vl.c                       |   11 +----------
 3 files changed, 17 insertions(+), 10 deletions(-)

diff --git a/include/qemu/config-file.h b/include/qemu/config-file.h
index dbd97c4..d4ba20e 100644
--- a/include/qemu/config-file.h
+++ b/include/qemu/config-file.h
@@ -8,6 +8,8 @@
 
 QemuOptsList *qemu_find_opts(const char *group);
 QemuOptsList *qemu_find_opts_err(const char *group, Error **errp);
+QemuOpts *qemu_find_opts_singleton(const char *group);
+
 void qemu_add_opts(QemuOptsList *list);
 void qemu_add_drive_opts(QemuOptsList *list);
 int qemu_set_option(const char *str);
diff --git a/util/qemu-config.c b/util/qemu-config.c
index f610101..60051df 100644
--- a/util/qemu-config.c
+++ b/util/qemu-config.c
@@ -39,6 +39,20 @@ QemuOptsList *qemu_find_opts(const char *group)
     return ret;
 }
 
+QemuOpts *qemu_find_opts_singleton(const char *group)
+{
+    QemuOptsList *list;
+    QemuOpts *opts;
+
+    list = qemu_find_opts(group);
+    assert(list);
+    opts = qemu_opts_find(list, NULL);
+    if (!opts) {
+        opts = qemu_opts_create(list, NULL, 0, &error_abort);
+    }
+    return opts;
+}
+
 static CommandLineParameterInfoList *query_option_descs(const QemuOptDesc *desc)
 {
     CommandLineParameterInfoList *param_list = NULL, *entry;
diff --git a/vl.c b/vl.c
index 685a7a9..7eb3b73 100644
--- a/vl.c
+++ b/vl.c
@@ -482,16 +482,7 @@ static QemuOptsList qemu_msg_opts = {
  */
 QemuOpts *qemu_get_machine_opts(void)
 {
-    QemuOptsList *list;
-    QemuOpts *opts;
-
-    list = qemu_find_opts("machine");
-    assert(list);
-    opts = qemu_opts_find(list, NULL);
-    if (!opts) {
-        opts = qemu_opts_create(list, NULL, 0, &error_abort);
-    }
-    return opts;
+    return qemu_find_opts_singleton("machine");
 }
 
 const char *qemu_get_vm_name(void)
-- 
1.7.1

[Qemu-trivial] [PATCH v4 2/2] vl: convert -m to QemuOpts

[Igor Mammedov]

Adds option to -m
 "size" - startup memory amount

For compatibility with legacy CLI if suffix-less number is passed,
it assumes amount in Mb.

Otherwise user is free to use suffixed number using suffixes b,k/K,M,G

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
v3:
 - fix not completed renaming of 'mem' option to 'size'
v2:
 - suggested by Andreas Färber <afaerber@suse.de>
    * s/fprintf/error_report/
    * rename 'mem' option to 'size'
 - fix conflict with missing numa QemuOpts
---
 qemu-options.hx |    9 ++++--
 vl.c            |   71 ++++++++++++++++++++++++++++++++++++++++++++-----------
 2 files changed, 63 insertions(+), 17 deletions(-)

diff --git a/qemu-options.hx b/qemu-options.hx
index 56e5fdf..5e89e0d 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -210,10 +210,13 @@ use is discouraged as it may be removed from future versions.
 ETEXI
 
 DEF("m", HAS_ARG, QEMU_OPTION_m,
-    "-m megs         set virtual RAM size to megs MB [default="
-    stringify(DEFAULT_RAM_SIZE) "]\n", QEMU_ARCH_ALL)
+    "-m [size=]megs\n"
+    "                configure guest RAM\n"
+    "                size: initial amount of guest memory (default: "
+    stringify(DEFAULT_RAM_SIZE) "MiB)\n",
+    QEMU_ARCH_ALL)
 STEXI
-@item -m @var{megs}
+@item -m [size=]@var{megs}
 @findex -m
 Set virtual RAM size to @var{megs} megabytes. Default is 128 MiB.  Optionally,
 a suffix of ``M'' or ``G'' can be used to signify a value in megabytes or
diff --git a/vl.c b/vl.c
index 7eb3b73..8b085c3 100644
--- a/vl.c
+++ b/vl.c
@@ -475,6 +475,20 @@ static QemuOptsList qemu_msg_opts = {
     },
 };
 
+static QemuOptsList qemu_mem_opts = {
+    .name = "memory",
+    .implied_opt_name = "size",
+    .head = QTAILQ_HEAD_INITIALIZER(qemu_mem_opts.head),
+    .merge_lists = true,
+    .desc = {
+        {
+            .name = "size",
+            .type = QEMU_OPT_SIZE,
+        },
+        { /* end of list */ }
+    },
+};
+
 /**
  * Get machine options
  *
@@ -2835,6 +2849,8 @@ int main(int argc, char **argv, char **envp)
     };
     const char *trace_events = NULL;
     const char *trace_file = NULL;
+    const ram_addr_t default_ram_size = (ram_addr_t)DEFAULT_RAM_SIZE *
+                                        1024 * 1024;
 
     atexit(qemu_run_exit_notifiers);
     error_set_progname(argv[0]);
@@ -2866,6 +2882,7 @@ int main(int argc, char **argv, char **envp)
     qemu_add_opts(&qemu_trace_opts);
     qemu_add_opts(&qemu_option_rom_opts);
     qemu_add_opts(&qemu_machine_opts);
+    qemu_add_opts(&qemu_mem_opts);
     qemu_add_opts(&qemu_smp_opts);
     qemu_add_opts(&qemu_boot_opts);
     qemu_add_opts(&qemu_sandbox_opts);
@@ -2889,7 +2906,7 @@ int main(int argc, char **argv, char **envp)
     module_call_init(MODULE_INIT_MACHINE);
     machine = find_default_machine();
     cpu_model = NULL;
-    ram_size = 0;
+    ram_size = default_ram_size;
     snapshot = 0;
     cyls = heads = secs = 0;
     translation = BIOS_ATA_TRANSLATION_AUTO;
@@ -3176,20 +3193,48 @@ int main(int argc, char **argv, char **envp)
                 exit(0);
                 break;
             case QEMU_OPTION_m: {
-                int64_t value;
                 uint64_t sz;
-                char *end;
+                const char *mem_str;
 
-                value = strtosz(optarg, &end);
-                if (value < 0 || *end) {
-                    fprintf(stderr, "qemu: invalid ram size: %s\n", optarg);
-                    exit(1);
+                opts = qemu_opts_parse(qemu_find_opts("memory"),
+                                       optarg, 1);
+                if (!opts) {
+                    exit(EXIT_FAILURE);
+                }
+
+                mem_str = qemu_opt_get(opts, "size");
+                if (!mem_str) {
+                    error_report("invalid -m option, missing 'size' option");
+                    exit(EXIT_FAILURE);
+                }
+                if (!*mem_str) {
+                    error_report("missing 'size' option value");
+                    exit(EXIT_FAILURE);
+                }
+
+                sz = qemu_opt_get_size(opts, "size", ram_size);
+
+                /* Fix up legacy suffix-less format */
+                if (g_ascii_isdigit(mem_str[strlen(mem_str) - 1])) {
+                    uint64_t overflow_check = sz;
+
+                    sz <<= 20;
+                    if ((sz >> 20) != overflow_check) {
+                        error_report("too large 'size' option value");
+                        exit(EXIT_FAILURE);
+                    }
+                }
+
+                /* backward compatibility behaviour for case "-m 0" */
+                if (sz == 0) {
+                    sz = default_ram_size;
                 }
-                sz = QEMU_ALIGN_UP((uint64_t)value, 8192);
+
+                sz = QEMU_ALIGN_UP(sz, 8192);
                 ram_size = sz;
                 if (ram_size != sz) {
-                    fprintf(stderr, "qemu: ram size too large\n");
-                    exit(1);
+                    error_report("ram size too large");
+                    exit(EXIT_FAILURE);
                 }
                 break;
             }
@@ -4034,10 +4079,8 @@ int main(int argc, char **argv, char **envp)
         exit(1);
     }
 
-    /* init the memory */
-    if (ram_size == 0) {
-        ram_size = DEFAULT_RAM_SIZE * 1024 * 1024;
-    }
+    /* store value for the future use */
+    qemu_opt_set_number(qemu_find_opts_singleton("memory"), "size", ram_size);
 
     if (qemu_opts_foreach(qemu_find_opts("device"), device_help_func, NULL, 0)
         != 0) {
-- 
1.7.1

[Qemu-devel] [PATCH v4 2/2] vl: convert -m to QemuOpts

[Igor Mammedov]

Adds option to -m
 "size" - startup memory amount

For compatibility with legacy CLI if suffix-less number is passed,
it assumes amount in Mb.

Otherwise user is free to use suffixed number using suffixes b,k/K,M,G

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
v3:
 - fix not completed renaming of 'mem' option to 'size'
v2:
 - suggested by Andreas Färber <afaerber@suse.de>
    * s/fprintf/error_report/
    * rename 'mem' option to 'size'
 - fix conflict with missing numa QemuOpts
---
 qemu-options.hx |    9 ++++--
 vl.c            |   71 ++++++++++++++++++++++++++++++++++++++++++++-----------
 2 files changed, 63 insertions(+), 17 deletions(-)

diff --git a/qemu-options.hx b/qemu-options.hx
index 56e5fdf..5e89e0d 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -210,10 +210,13 @@ use is discouraged as it may be removed from future versions.
 ETEXI
 
 DEF("m", HAS_ARG, QEMU_OPTION_m,
-    "-m megs         set virtual RAM size to megs MB [default="
-    stringify(DEFAULT_RAM_SIZE) "]\n", QEMU_ARCH_ALL)
+    "-m [size=]megs\n"
+    "                configure guest RAM\n"
+    "                size: initial amount of guest memory (default: "
+    stringify(DEFAULT_RAM_SIZE) "MiB)\n",
+    QEMU_ARCH_ALL)
 STEXI
-@item -m @var{megs}
+@item -m [size=]@var{megs}
 @findex -m
 Set virtual RAM size to @var{megs} megabytes. Default is 128 MiB.  Optionally,
 a suffix of ``M'' or ``G'' can be used to signify a value in megabytes or
diff --git a/vl.c b/vl.c
index 7eb3b73..8b085c3 100644
--- a/vl.c
+++ b/vl.c
@@ -475,6 +475,20 @@ static QemuOptsList qemu_msg_opts = {
     },
 };
 
+static QemuOptsList qemu_mem_opts = {
+    .name = "memory",
+    .implied_opt_name = "size",
+    .head = QTAILQ_HEAD_INITIALIZER(qemu_mem_opts.head),
+    .merge_lists = true,
+    .desc = {
+        {
+            .name = "size",
+            .type = QEMU_OPT_SIZE,
+        },
+        { /* end of list */ }
+    },
+};
+
 /**
  * Get machine options
  *
@@ -2835,6 +2849,8 @@ int main(int argc, char **argv, char **envp)
     };
     const char *trace_events = NULL;
     const char *trace_file = NULL;
+    const ram_addr_t default_ram_size = (ram_addr_t)DEFAULT_RAM_SIZE *
+                                        1024 * 1024;
 
     atexit(qemu_run_exit_notifiers);
     error_set_progname(argv[0]);
@@ -2866,6 +2882,7 @@ int main(int argc, char **argv, char **envp)
     qemu_add_opts(&qemu_trace_opts);
     qemu_add_opts(&qemu_option_rom_opts);
     qemu_add_opts(&qemu_machine_opts);
+    qemu_add_opts(&qemu_mem_opts);
     qemu_add_opts(&qemu_smp_opts);
     qemu_add_opts(&qemu_boot_opts);
     qemu_add_opts(&qemu_sandbox_opts);
@@ -2889,7 +2906,7 @@ int main(int argc, char **argv, char **envp)
     module_call_init(MODULE_INIT_MACHINE);
     machine = find_default_machine();
     cpu_model = NULL;
-    ram_size = 0;
+    ram_size = default_ram_size;
     snapshot = 0;
     cyls = heads = secs = 0;
     translation = BIOS_ATA_TRANSLATION_AUTO;
@@ -3176,20 +3193,48 @@ int main(int argc, char **argv, char **envp)
                 exit(0);
                 break;
             case QEMU_OPTION_m: {
-                int64_t value;
                 uint64_t sz;
-                char *end;
+                const char *mem_str;
 
-                value = strtosz(optarg, &end);
-                if (value < 0 || *end) {
-                    fprintf(stderr, "qemu: invalid ram size: %s\n", optarg);
-                    exit(1);
+                opts = qemu_opts_parse(qemu_find_opts("memory"),
+                                       optarg, 1);
+                if (!opts) {
+                    exit(EXIT_FAILURE);
+                }
+
+                mem_str = qemu_opt_get(opts, "size");
+                if (!mem_str) {
+                    error_report("invalid -m option, missing 'size' option");
+                    exit(EXIT_FAILURE);
+                }
+                if (!*mem_str) {
+                    error_report("missing 'size' option value");
+                    exit(EXIT_FAILURE);
+                }
+
+                sz = qemu_opt_get_size(opts, "size", ram_size);
+
+                /* Fix up legacy suffix-less format */
+                if (g_ascii_isdigit(mem_str[strlen(mem_str) - 1])) {
+                    uint64_t overflow_check = sz;
+
+                    sz <<= 20;
+                    if ((sz >> 20) != overflow_check) {
+                        error_report("too large 'size' option value");
+                        exit(EXIT_FAILURE);
+                    }
+                }
+
+                /* backward compatibility behaviour for case "-m 0" */
+                if (sz == 0) {
+                    sz = default_ram_size;
                 }
-                sz = QEMU_ALIGN_UP((uint64_t)value, 8192);
+
+                sz = QEMU_ALIGN_UP(sz, 8192);
                 ram_size = sz;
                 if (ram_size != sz) {
-                    fprintf(stderr, "qemu: ram size too large\n");
-                    exit(1);
+                    error_report("ram size too large");
+                    exit(EXIT_FAILURE);
                 }
                 break;
             }
@@ -4034,10 +4079,8 @@ int main(int argc, char **argv, char **envp)
         exit(1);
     }
 
-    /* init the memory */
-    if (ram_size == 0) {
-        ram_size = DEFAULT_RAM_SIZE * 1024 * 1024;
-    }
+    /* store value for the future use */
+    qemu_opt_set_number(qemu_find_opts_singleton("memory"), "size", ram_size);
 
     if (qemu_opts_foreach(qemu_find_opts("device"), device_help_func, NULL, 0)
         != 0) {
-- 
1.7.1

Re: [Qemu-trivial] [Qemu-devel] [PATCH v4 2/2] vl: convert -m to QemuOpts

[Andreas Färber]

Am 06.03.2014 10:39, schrieb Igor Mammedov:
> Adds option to -m
>  "size" - startup memory amount
> 
> For compatibility with legacy CLI if suffix-less number is passed,
> it assumes amount in Mb.
> 
> Otherwise user is free to use suffixed number using suffixes b,k/K,M,G
> 
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>

Reviewed-by: Andreas Färber <afaerber@suse.de>

Thanks,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

Re: [Qemu-devel] [PATCH v4 2/2] vl: convert -m to QemuOpts

[Andreas Färber]

Am 06.03.2014 10:39, schrieb Igor Mammedov:
> Adds option to -m
>  "size" - startup memory amount
> 
> For compatibility with legacy CLI if suffix-less number is passed,
> it assumes amount in Mb.
> 
> Otherwise user is free to use suffixed number using suffixes b,k/K,M,G
> 
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>

Reviewed-by: Andreas Färber <afaerber@suse.de>

Thanks,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

Re: [Qemu-trivial] [Qemu-devel] [PATCH v4 0/2] convert -m to QemuOpts

[Andreas Färber]

mjt,

Am 06.03.2014 10:39, schrieb Igor Mammedov:
> Igor Mammedov (1):
>   vl: convert -m to QemuOpts
> 
> Paolo Bonzini (1):
>   qemu-option: introduce qemu_find_opts_singleton
> 
>  include/qemu/config-file.h |    2 +
>  qemu-options.hx            |    9 +++--
>  util/qemu-config.c         |   14 +++++++
>  vl.c                       |   82 +++++++++++++++++++++++++++++++-------------
>  4 files changed, 80 insertions(+), 27 deletions(-)

Since I believe you have a track record of reviewing and queuing such
QemuOpts conversions, can you review and take this for 2.0 please?

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

Re: [Qemu-devel] [PATCH v4 0/2] convert -m to QemuOpts

[Andreas Färber]

mjt,

Am 06.03.2014 10:39, schrieb Igor Mammedov:
> Igor Mammedov (1):
>   vl: convert -m to QemuOpts
> 
> Paolo Bonzini (1):
>   qemu-option: introduce qemu_find_opts_singleton
> 
>  include/qemu/config-file.h |    2 +
>  qemu-options.hx            |    9 +++--
>  util/qemu-config.c         |   14 +++++++
>  vl.c                       |   82 +++++++++++++++++++++++++++++++-------------
>  4 files changed, 80 insertions(+), 27 deletions(-)

Since I believe you have a track record of reviewing and queuing such
QemuOpts conversions, can you review and take this for 2.0 please?

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

Re: [Qemu-trivial] [Qemu-devel] [PATCH v4 0/2] convert -m to QemuOpts

[Igor Mammedov]

On Thu, 06 Mar 2014 20:32:39 +0100
Andreas Färber <afaerber@suse.de> wrote:

> mjt,
[...]
> Since I believe you have a track record of reviewing and queuing such
> QemuOpts conversions, can you review and take this for 2.0 please?
ping

> 
> Regards,
> Andreas
> 
> -- 
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg


-- 
Regards,
  Igor

Re: [Qemu-devel] [PATCH v4 0/2] convert -m to QemuOpts

[Igor Mammedov]

On Thu, 06 Mar 2014 20:32:39 +0100
Andreas Färber <afaerber@suse.de> wrote:

> mjt,
[...]
> Since I believe you have a track record of reviewing and queuing such
> QemuOpts conversions, can you review and take this for 2.0 please?
ping

> 
> Regards,
> Andreas
> 
> -- 
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg


-- 
Regards,
  Igor

Re: [Qemu-trivial] [Qemu-devel] [PATCH v4 0/2] convert -m to QemuOpts

[Michael Tokarev]

16.03.2014 00:26, Igor Mammedov wrote:
> On Thu, 06 Mar 2014 20:32:39 +0100
> Andreas Färber <afaerber@suse.de> wrote:
> 
>> mjt,
> [...]
>> Since I believe you have a track record of reviewing and queuing such
>> QemuOpts conversions, can you review and take this for 2.0 please?
> ping

I'm really sorry for this.  Somehow I thought to queue it PAST 2.0, not FOR 2.0.

Oh well.

/mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH v4 0/2] convert -m to QemuOpts

[Michael Tokarev]

16.03.2014 00:26, Igor Mammedov wrote:
> On Thu, 06 Mar 2014 20:32:39 +0100
> Andreas Färber <afaerber@suse.de> wrote:
> 
>> mjt,
> [...]
>> Since I believe you have a track record of reviewing and queuing such
>> QemuOpts conversions, can you review and take this for 2.0 please?
> ping

I'm really sorry for this.  Somehow I thought to queue it PAST 2.0, not FOR 2.0.

Oh well.

/mjt

Re: [Qemu-trivial] [PATCH v4 0/2] convert -m to QemuOpts

[Michael Tokarev]

06.03.2014 13:39, Igor Mammedov wrote:
> Igor Mammedov (1):
>   vl: convert -m to QemuOpts

This patch (2/2) was mime-damaged, I had to edit it manually
in order for it to apply.  Please take a look at
http://git.corpit.ru/?p=qemu.git;a=shortlog;h=refs/heads/trivial-patches-next
to verify it's okay.

Applied to -trivial.

Thanks,

/mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH v4 0/2] convert -m to QemuOpts

[Michael Tokarev]

06.03.2014 13:39, Igor Mammedov wrote:
> Igor Mammedov (1):
>   vl: convert -m to QemuOpts

This patch (2/2) was mime-damaged, I had to edit it manually
in order for it to apply.  Please take a look at
http://git.corpit.ru/?p=qemu.git;a=shortlog;h=refs/heads/trivial-patches-next
to verify it's okay.

Applied to -trivial.

Thanks,

/mjt

Re: [Qemu-trivial] [Qemu-devel] [PATCH v4 0/2] convert -m to QemuOpts

[Igor Mammedov]

On Thu, 20 Mar 2014 20:21:14 +0400
Michael Tokarev <mjt@tls.msk.ru> wrote:

> 06.03.2014 13:39, Igor Mammedov wrote:
> > Igor Mammedov (1):
> >   vl: convert -m to QemuOpts
> 
> This patch (2/2) was mime-damaged, I had to edit it manually
> in order for it to apply.  Please take a look at
> http://git.corpit.ru/?p=qemu.git;a=shortlog;h=refs/heads/trivial-patches-next
> to verify it's okay.
I'm sorry for not providing link to git repo to pull from.
I can't check because it looks like site is unreachable from my place.

here is git tree with patch rebased on top of today's tree to compare with/pull from:
https://github.com/imammedo/qemu/commits/qoptify-m.v4

https://github.com/imammedo/qemu/commit/548b68295bf4967b1dd950f6d84a88b782f17f41

Thanks,
 Igor

> 
> Applied to -trivial.
> 
> Thanks,
> 
> /mjt
> 

Re: [Qemu-devel] [Qemu-trivial] [PATCH v4 0/2] convert -m to QemuOpts

[Igor Mammedov]

On Thu, 20 Mar 2014 20:21:14 +0400
Michael Tokarev <mjt@tls.msk.ru> wrote:

> 06.03.2014 13:39, Igor Mammedov wrote:
> > Igor Mammedov (1):
> >   vl: convert -m to QemuOpts
> 
> This patch (2/2) was mime-damaged, I had to edit it manually
> in order for it to apply.  Please take a look at
> http://git.corpit.ru/?p=qemu.git;a=shortlog;h=refs/heads/trivial-patches-next
> to verify it's okay.
I'm sorry for not providing link to git repo to pull from.
I can't check because it looks like site is unreachable from my place.

here is git tree with patch rebased on top of today's tree to compare with/pull from:
https://github.com/imammedo/qemu/commits/qoptify-m.v4

https://github.com/imammedo/qemu/commit/548b68295bf4967b1dd950f6d84a88b782f17f41

Thanks,
 Igor

> 
> Applied to -trivial.
> 
> Thanks,
> 
> /mjt
> 

Re: [Qemu-trivial] [Qemu-devel] [PATCH v4 0/2] convert -m to QemuOpts

[Igor Mammedov]

On Thu, 20 Mar 2014 20:21:14 +0400
Michael Tokarev <mjt@tls.msk.ru> wrote:

> 06.03.2014 13:39, Igor Mammedov wrote:
> > Igor Mammedov (1):
> >   vl: convert -m to QemuOpts
> 
> This patch (2/2) was mime-damaged, I had to edit it manually
> in order for it to apply.  Please take a look at
> http://git.corpit.ru/?p=qemu.git;a=shortlog;h=refs/heads/trivial-patches-next
> to verify it's okay.
> 
> Applied to -trivial.
seeing your today's PULL trivial req,
it looks like this patch was lost from your queue,
could you reapply it please?

> 
> Thanks,
> 
> /mjt
> 

Re: [Qemu-trivial] [Qemu-devel] [PATCH v4 0/2] convert -m to QemuOpts

[Michael Tokarev]

18.04.2014 11:18, Igor Mammedov wrote:
> On Thu, 20 Mar 2014 20:21:14 +0400
> Michael Tokarev <mjt@tls.msk.ru> wrote:
> 
>> 06.03.2014 13:39, Igor Mammedov wrote:
>>> Igor Mammedov (1):
>>>   vl: convert -m to QemuOpts
>>
>> This patch (2/2) was mime-damaged, I had to edit it manually
>> in order for it to apply.  Please take a look at
>> http://git.corpit.ru/?p=qemu.git;a=shortlog;h=refs/heads/trivial-patches-next
>> to verify it's okay.
>>
>> Applied to -trivial.
> seeing your today's PULL trivial req,
> it looks like this patch was lost from your queue,
> could you reapply it please?

It isn't lost, it is waiting in a -next branch.
I just re-sent a previous pullreq which were targetted 2.0
but hasn't been applied for 2.0.

Other stuff (about 20 other patches) is waiting.

Thank you for the reminder.  Having in mind my previous
sloppery with this stuff it is good to be reminded again,
to not repeat past mistakes!

/mjt

Re: [Qemu-trivial] [PATCH v4 0/2] convert -m to QemuOpts

[Michael Tokarev]

Thanks, applied to trivial patches.

Finally.

/mjt