Re: [Qemu-devel] [RFC PATCH V2 5/5] qapi event: convert RTC_CHANGE

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 996 bytes --]

On 01/02/2014 04:10 PM, Wenchao Xia wrote:
> This is just an example of how to use qapi event API, and it
> bypassed the event throttle queue. A complete convert should
> be first define all events in qapi-schema.json, use qapi
> event types in monitor functions, then change calller one

s/calller/caller/

> by one.
> 
> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
> ---
>  monitor.c        |   14 ++++++++++++++
>  qapi-schema.json |    3 +++
>  vl.c             |    7 ++-----
>  3 files changed, 19 insertions(+), 5 deletions(-)
> 

> +++ b/qapi-schema.json
> @@ -4247,3 +4247,6 @@
>  # Since: 1.7
>  ##
>  { 'command': 'blockdev-add', 'data': { 'options': 'BlockdevOptions' } }
> +
> +{ 'event': 'RTC_CHANGE',

You'll need to add documentation before each 'event' (hint - crib the
existing documentation we already have in qmp-events.txt)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]