From: Vandana Kannan <vandana.kannan@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 3/6] drm/i915: Add support for DRRS to switch RR
Date: Fri, 07 Mar 2014 14:11:30 +0530 [thread overview]
Message-ID: <5319863A.9090308@intel.com> (raw)
In-Reply-To: <20140305095810.GB20735@nuc-i3427.alporthouse.com>
On Mar-05-2014 3:28 PM, Chris Wilson wrote:
> On Wed, Mar 05, 2014 at 03:13:06PM +0530, Vandana Kannan wrote:
>> +void intel_dp_set_drrs_state(struct drm_device *dev, int refresh_rate)
>> +{
>> + struct drm_i915_private *dev_priv = dev->dev_private;
>> + struct intel_encoder *encoder;
>> + struct intel_dp *intel_dp = NULL;
>> + struct intel_crtc_config *config = NULL;
>> + struct intel_crtc *intel_crtc = NULL;
>> + struct intel_connector *intel_connector = dev_priv->drrs.connector;
>> + u32 reg, val;
>> + int index = 0;
>
> This routine touches a register and reads state guarded by modeset locks,
> I don't see any documentation to make sure the caller complies with
> holding the right locks.
>
> And since this function isn't used yet, I can't check that the callers
> are correct at this point in time either. Please, please do document
> locking requirements on new functions.
> -Chris
>
Thanks for your inputs. I have added a short description explaining that
the locking may be required for future implementations/enhancements of DRRS.
I have pushed the revised set of patches.
-Vandana
next prev parent reply other threads:[~2014-03-07 8:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 9:43 [PATCH 0/6] v6: Enabling DRRS in the kernel Vandana Kannan
2014-03-05 9:43 ` [PATCH 1/6] drm/i915: Adding VBT fields to support eDP DRRS feature Vandana Kannan
2014-03-05 9:43 ` [PATCH 2/6] drm/i915: Parse EDID probed modes for DRRS support Vandana Kannan
2014-03-05 9:43 ` [PATCH 3/6] drm/i915: Add support for DRRS to switch RR Vandana Kannan
2014-03-05 9:58 ` Chris Wilson
2014-03-07 8:41 ` Vandana Kannan [this message]
2014-03-05 9:43 ` [PATCH 4/6] drm/i915: Idleness detection for DRRS Vandana Kannan
2014-03-05 9:43 ` [PATCH 5/6] drm/i915/bdw: Add support for DRRS to switch RR Vandana Kannan
2014-03-05 9:43 ` [PATCH 6/6] drm/i915: Support for RR switching on VLV Vandana Kannan
-- strict thread matches above, loose matches on Subject: below --
2014-03-07 5:17 [PATCH 0/6] v6: Enabling DRRS in the kernel Vandana Kannan
2014-03-07 5:17 ` [PATCH 3/6] drm/i915: Add support for DRRS to switch RR Vandana Kannan
2014-03-26 12:55 ` Jani Nikula
2014-03-27 8:59 ` Vandana Kannan
2014-03-28 4:44 [PATCH 0/6] v7: Enabling DRRS in the kernel Vandana Kannan
2014-03-28 4:44 ` [PATCH 3/6] drm/i915: Add support for DRRS to switch RR Vandana Kannan
2014-04-01 13:25 ` Jani Nikula
2014-04-02 5:58 ` Vandana Kannan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5319863A.9090308@intel.com \
--to=vandana.kannan@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.