From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH 0/2] fix performance/cache resource issues
	with 128-byte cache line targets
Date: Mon, 07 Dec 2015 15:35:58 +0100
Message-ID: <5319870.TBdLd4mWKW@xps13>
References: <1449417564-29600-1-git-send-email-jerin.jacob@caviumnetworks.com>
 <1624480.dTEes5qyS3@xps13> <20151207143300.GA20063@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52])
 by dpdk.org (Postfix) with ESMTP id ECBF195D4
 for <dev@dpdk.org>; Mon,  7 Dec 2015 15:37:11 +0100 (CET)
Received: by wmuu63 with SMTP id u63so143064169wmu.0
 for <dev@dpdk.org>; Mon, 07 Dec 2015 06:37:11 -0800 (PST)
In-Reply-To: <20151207143300.GA20063@localhost.localdomain>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-12-07 20:03, Jerin Jacob:
> On Mon, Dec 07, 2015 at 03:40:13AM -0800, Thomas Monjalon wrote:
> > 2015-12-07 12:56, Jerin Jacob:
> > > On Sun, Dec 06, 2015 at 05:30:50PM +0100, Thomas Monjalon wrote:
> > > > 2015-12-06 21:29, Jerin Jacob:
> > > > > This patchset fixes performance/cache resource issues with 128-byte cache line targets
> > > > > found in mbuf and bitmap DPDK libraries
> > > > > 
> > > > > Currently, we have two DPDK targets(ThunderX and ppc_64) which are based on
> > > > > 128-bytes cache line size target.
> > > > 
> > > > When introducing IBM Power8, we failed to clean the cache line size definition.
> > > > I promised to not forget this issue in this thread with Neil:
> > > > 	http://dpdk.org/ml/archives/dev/2014-December/009439.html
> > > > 
> > > > It is defined in
> > > > 	config/defconfig_*
> > > > 	mk/machine/*/rte.vars.mk
> > > > 	mk/arch/*/rte.vars.mk
> > > > 	rte_memory.h
> > > > 	rte_kni_common.h
> > > > 
> > > > It should be defined only in the config files.
> > > > When we will introduce a configure script, we should be able to detect it.
> > > > 
> > > > Please Jerin, as ThunderX maintainer, may you help to fix this old mess?
> > > 
> > > Yes Thomas, I will takeup this issue when we will have configure script.
> > 
> > I thought we could start setting the value in only one place.
> > The detection in configure script would be another step.
> 
> OK Thomas, I have sent the cleanup patch. Please review it.

You are too fast :)
I will review it but it will be deferred to 2.3.