From: George Cherian <george.cherian@ti.com>
To: Roger Quadros <rogerq@ti.com>,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
devicetree@vger.kernel.org, linux-omap@vger.kernel.org
Cc: balbi@ti.com, kishon@ti.com, rob@landley.net,
galak@codeaurora.org, ijc+devicetree@hellion.org.uk,
mark.rutland@arm.com, pawel.moll@arm.com, robh+dt@kernel.org,
tony@atomide.com, anatol.pomozov@gmail.com,
bcousson@baylibre.com
Subject: Re: [PATCH v2 4/5] ARM: dts: am437x-gp-evm: Enable USB
Date: Fri, 7 Mar 2014 16:01:08 +0530 [thread overview]
Message-ID: <53199FEC.4020009@ti.com> (raw)
In-Reply-To: <53199E88.8000800@ti.com>
On 3/7/2014 3:55 PM, Roger Quadros wrote:
> Hi George,
>
> On 03/07/2014 11:15 AM, George Cherian wrote:
>> Enable
>> - ocp2scp
>> - USB PHY control module
>> - USB PHY
>> - dwc3_omap
>> - USB
>> for am437x-gp-evm
>>
>> Signed-off-by: George Cherian <george.cherian@ti.com>
>> ---
>> arch/arm/boot/dts/am437x-gp-evm.dts | 28 ++++++++++++++++++++++++++++
>> 1 file changed, 28 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/am437x-gp-evm.dts b/arch/arm/boot/dts/am437x-gp-evm.dts
>> index 4eb72b8..1d516a7 100644
>> --- a/arch/arm/boot/dts/am437x-gp-evm.dts
>> +++ b/arch/arm/boot/dts/am437x-gp-evm.dts
>> @@ -98,3 +98,31 @@
>> &gpio4 {
>> status = "okay";
>> };
>> +
>> +
>> +&usb2_phy1 {
>> + status = "okay";
>> +};
>> +
>> +&dwc3_1 {
>> + status = "okay";
>> +};
> Do you need to explicitly enable dwc3_1 nand dwc3_2?
Ahhh... Fixed only in am4372.dtsi
Same with patch 5, I will resend the series fixing it.
>
>> +
>> +&usb1 {
>> + dr_mode = "peripheral";
>> + status = "okay";
>> +};
>> +
>> +
>> +&usb2_phy2 {
>> + status = "okay";
>> +};
>> +
>> +&dwc3_2 {
>> + status = "okay";
>> +};
>> +
>> +&usb2 {
>> + dr_mode = "host";
>> + status = "okay";
>> +};
>>
> cheers,
> -roger
--
-George
WARNING: multiple messages have this Message-ID (diff)
From: George Cherian <george.cherian@ti.com>
To: Roger Quadros <rogerq@ti.com>, <linux-kernel@vger.kernel.org>,
<linux-doc@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-omap@vger.kernel.org>
Cc: <balbi@ti.com>, <kishon@ti.com>, <rob@landley.net>,
<galak@codeaurora.org>, <ijc+devicetree@hellion.org.uk>,
<mark.rutland@arm.com>, <pawel.moll@arm.com>,
<robh+dt@kernel.org>, <tony@atomide.com>,
<anatol.pomozov@gmail.com>, <bcousson@baylibre.com>
Subject: Re: [PATCH v2 4/5] ARM: dts: am437x-gp-evm: Enable USB
Date: Fri, 7 Mar 2014 16:01:08 +0530 [thread overview]
Message-ID: <53199FEC.4020009@ti.com> (raw)
In-Reply-To: <53199E88.8000800@ti.com>
On 3/7/2014 3:55 PM, Roger Quadros wrote:
> Hi George,
>
> On 03/07/2014 11:15 AM, George Cherian wrote:
>> Enable
>> - ocp2scp
>> - USB PHY control module
>> - USB PHY
>> - dwc3_omap
>> - USB
>> for am437x-gp-evm
>>
>> Signed-off-by: George Cherian <george.cherian@ti.com>
>> ---
>> arch/arm/boot/dts/am437x-gp-evm.dts | 28 ++++++++++++++++++++++++++++
>> 1 file changed, 28 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/am437x-gp-evm.dts b/arch/arm/boot/dts/am437x-gp-evm.dts
>> index 4eb72b8..1d516a7 100644
>> --- a/arch/arm/boot/dts/am437x-gp-evm.dts
>> +++ b/arch/arm/boot/dts/am437x-gp-evm.dts
>> @@ -98,3 +98,31 @@
>> &gpio4 {
>> status = "okay";
>> };
>> +
>> +
>> +&usb2_phy1 {
>> + status = "okay";
>> +};
>> +
>> +&dwc3_1 {
>> + status = "okay";
>> +};
> Do you need to explicitly enable dwc3_1 nand dwc3_2?
Ahhh... Fixed only in am4372.dtsi
Same with patch 5, I will resend the series fixing it.
>
>> +
>> +&usb1 {
>> + dr_mode = "peripheral";
>> + status = "okay";
>> +};
>> +
>> +
>> +&usb2_phy2 {
>> + status = "okay";
>> +};
>> +
>> +&dwc3_2 {
>> + status = "okay";
>> +};
>> +
>> +&usb2 {
>> + dr_mode = "host";
>> + status = "okay";
>> +};
>>
> cheers,
> -roger
--
-George
next prev parent reply other threads:[~2014-03-07 10:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-07 9:15 [PATCH v2 0/5] Add USB nodes for am43xx epos and gp evm George Cherian
2014-03-07 9:15 ` George Cherian
2014-03-07 9:15 ` [PATCH v2 1/5] doc: Add "ti,am437x-dwc3" comaptible for dwc3 glue George Cherian
2014-03-07 9:15 ` George Cherian
2014-03-07 9:15 ` [PATCH v2 2/5] ARM: dts: am43xx clock data George Cherian
2014-03-07 9:15 ` George Cherian
2014-03-07 9:15 ` [PATCH v2 3/5] ARM: dts: AM4372: Add USB nodes George Cherian
2014-03-07 9:15 ` George Cherian
2014-03-07 10:21 ` Roger Quadros
2014-03-07 10:21 ` Roger Quadros
2014-03-07 9:15 ` [PATCH v2 4/5] ARM: dts: am437x-gp-evm: Enable USB George Cherian
2014-03-07 9:15 ` George Cherian
[not found] ` <1394183758-3821-5-git-send-email-george.cherian-l0cyMroinI0@public.gmane.org>
2014-03-07 10:25 ` Roger Quadros
2014-03-07 10:25 ` Roger Quadros
2014-03-07 10:31 ` George Cherian [this message]
2014-03-07 10:31 ` George Cherian
2014-03-07 9:15 ` [PATCH v2 5/5] ARM: dts: am43x-epos-evm: " George Cherian
2014-03-07 9:15 ` George Cherian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53199FEC.4020009@ti.com \
--to=george.cherian@ti.com \
--cc=anatol.pomozov@gmail.com \
--cc=balbi@ti.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kishon@ti.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
--cc=rogerq@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.