All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: linux-fbdev@vger.kernel.org
Subject: Re: [patch -resend] sisfb: fix 1280x720 resolution support
Date: Fri, 07 Mar 2014 12:20:51 +0000	[thread overview]
Message-ID: <5319B9A3.7050100@ti.com> (raw)
In-Reply-To: <20140307111853.GB2351@elgon.mountain>

[-- Attachment #1: Type: text/plain, Size: 745 bytes --]

On 07/03/14 13:18, Dan Carpenter wrote:
> It uses the wrong mode index because there is no break statement.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/video/fbdev/sis/init.c b/drivers/video/fbdev/sis/init.c
> index 4f26bc28e60b..bd40f5ecd901 100644
> --- a/drivers/video/fbdev/sis/init.c
> +++ b/drivers/video/fbdev/sis/init.c
> @@ -651,6 +651,7 @@ SiS_GetModeID_LCD(int VGAEngine, unsigned int VBFlags, int HDisplay, int VDispla
>  	     switch(VDisplay) {
>  	     case 720:
>  		ModeIndex = ModeIndex_1280x720[Depth];
> +		break;
>  	     case 768:
>  		if(VGAEngine == SIS_300_VGA) {
>  		   ModeIndex = ModeIndex_300_1280x768[Depth];
> 

Thanks, queued for 3.15.

 Tomi



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]

      reply	other threads:[~2014-03-07 12:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-07 11:18 [patch -resend] sisfb: fix 1280x720 resolution support Dan Carpenter
2014-03-07 12:20 ` Tomi Valkeinen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5319B9A3.7050100@ti.com \
    --to=tomi.valkeinen@ti.com \
    --cc=linux-fbdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.