From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52624) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLuuP-0004Fc-EG for qemu-devel@nongnu.org; Fri, 07 Mar 2014 08:33:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WLuuK-0002Am-Qs for qemu-devel@nongnu.org; Fri, 07 Mar 2014 08:33:53 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41049) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLuuK-0002Aa-IQ for qemu-devel@nongnu.org; Fri, 07 Mar 2014 08:33:48 -0500 Message-ID: <5319CAB7.3080805@redhat.com> Date: Fri, 07 Mar 2014 06:33:43 -0700 From: Eric Blake MIME-Version: 1.0 References: <1394028846-9408-1-git-send-email-romain@dolbeau.org> <1394198414-22504-1-git-send-email-romain@dolbeau.org> <1394198414-22504-3-git-send-email-romain@dolbeau.org> In-Reply-To: <1394198414-22504-3-git-send-email-romain@dolbeau.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xasqKmM868q2Slhher5LxeqEXuuwWX1Ce" Subject: Re: [Qemu-devel] [PATCH 2/2 V4] spaces around '<<' everywhere List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Romain Dolbeau , qemu-devel@nongnu.org Cc: Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --xasqKmM868q2Slhher5LxeqEXuuwWX1Ce Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/07/2014 06:20 AM, Romain Dolbeau wrote: > Signed-off-by: Romain Dolbeau > --- > hw/net/e1000.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > if (++s->eecd_state.bitnum_in =3D=3D 9 && !s->eecd_state.reading) = { > - s->eecd_state.bitnum_out =3D ((s->eecd_state.val_in & 0x3f)<<4= )-1; > + s->eecd_state.bitnum_out =3D ((s->eecd_state.val_in & 0x3f) <<= 4)-1; If you're fixing operator spacing, why not also fix the spacing around binary '-' at the same time? > for (i =3D 0; i < 3; i++) { > - d->eeprom_data[i] =3D (macaddr[2*i+1]<<8) | macaddr[2*i]; > + d->eeprom_data[i] =3D (macaddr[2*i+1] << 8) | macaddr[2*i]= ; Likewise around * and + --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --xasqKmM868q2Slhher5LxeqEXuuwWX1Ce Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTGcq3AAoJEKeha0olJ0NqBwgH/2NxlnAK3DAAxPIcxcp56wmW lZ31GR99VMREbBX9BHZTlMT3a1wcsX2QUxwaUbrhGcJw2fvR5yJDUQeDKkuShWrB hCia5Nik0zDbxFCIxOY4kYqA2nHHUhvAsNIqYxEdyv0e32PQu31sCj8LalDFt9OJ OOUSOxNFVwE0k3hIIIopl1qY+gfpv5MH6w3kJFJMj8LKDAqzZuj5PnL8cm+prvsq ofsI1VL8ypSO26QxORcvkKMboYKooDinBFou/8mLxkw9uJUVSEC9hZtsi8Acz1gd r5j7KeuaKCbOI5hdDj45HUjoTOIT8dOBuhVw/VfuIhh3odx1ThLfBS8Rz0W4Z84= =WGqU -----END PGP SIGNATURE----- --xasqKmM868q2Slhher5LxeqEXuuwWX1Ce--