From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53356) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLuw5-0007iv-IO for qemu-devel@nongnu.org; Fri, 07 Mar 2014 08:35:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WLuvx-000319-VG for qemu-devel@nongnu.org; Fri, 07 Mar 2014 08:35:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36198) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLuvx-00030z-MY for qemu-devel@nongnu.org; Fri, 07 Mar 2014 08:35:29 -0500 Message-ID: <5319CB0D.30307@redhat.com> Date: Fri, 07 Mar 2014 14:35:09 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1393941656-29068-1-git-send-email-pbonzini@redhat.com> <531704E2.3010406@suse.de> <53170AD6.3040809@redhat.com> <5319B48A.3050500@suse.de> <5319B99D.7070200@redhat.com> <20140307135627.55d135ac@thinkpad> In-Reply-To: <20140307135627.55d135ac@thinkpad> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2.1 00/28] Current state of NUMA series, and hostmem improvements List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: ehabkost@redhat.com, hutao@cn.fujitsu.com, mtosatti@redhat.com, qemu-devel@nongnu.org, Anthony Liguori , Chen Fan , a.motakis@virtualopensystems.com, =?ISO-8859-1?Q?Andreas_F=E4rber?= , gaowanlong@cn.fujitsu.com Il 07/03/2014 13:56, Igor Mammedov ha scritto: >> However, I'd still like it to be mostly a container, and that is why I >> liked the idea of having /node[n] with "flat" links to the actual >> CPUStates (and also memdevs). > > Is there a point in having flat links to CPUState at /nodeX level, Easily getting thread ids for the VCPU thread and pinning them to host nodes? For this you need to match the CPU numbers passed to "-numa node", not some socket topology that can be completely arbitrary. Paolo > idea to create [*] /node[x]/socket[y]/core[z]/link[j] tree, was > suggested as way: > 1. to expose stable arch independent topology interface to user > 2. use * as argument to -device / device_add/del cpu,path=foo to avoid > exposing arch dependent APIC ID to the user. > while keeping /machine/node/socket/core objects mostly as containers to express > above things. > >> >>>> I think we can. Children and links look exactly the same from the outside. >>> >>> Well, we can't qom-get/qom-set a path string from/to a child<> property, >>> can we? >> >> We can get it but not set it. But Stefan's series provides a way to >> make links read-only too, and these links should be read-only I think. > CPUState links are readonly only until no hotplug supported. > >> >> Paolo > >