From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tero Kristo Subject: Re: [PATCH 1/8] CLK: ti: dra7: Initialize USB_DPLL Date: Fri, 7 Mar 2014 15:43:14 +0200 Message-ID: <5319CCF2.8090902@ti.com> References: <1394197751-28984-1-git-send-email-rogerq@ti.com> <1394197751-28984-2-git-send-email-rogerq@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1394197751-28984-2-git-send-email-rogerq@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Roger Quadros , balbi@ti.com, tony@atomide.com Cc: devicetree@vger.kernel.org, george.cherian@ti.com, Mike Turquette , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, kishon@ti.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-omap@vger.kernel.org On 03/07/2014 03:09 PM, Roger Quadros wrote: > USB_DPLL must be initialized and locked at boot so that > USB modules can work. > > Also program USB_DLL_M2 output to half rate. > > CC: Mike Turquette > CC: Tero Kristo > Signed-off-by: Roger Quadros > --- > drivers/clk/ti/clk-7xx.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/clk/ti/clk-7xx.c b/drivers/clk/ti/clk-7xx.c > index 9977653..f89f3c2 100644 > --- a/drivers/clk/ti/clk-7xx.c > +++ b/drivers/clk/ti/clk-7xx.c > @@ -18,6 +18,7 @@ > > #define DRA7_DPLL_ABE_DEFFREQ 361267200 > #define DRA7_DPLL_GMAC_DEFFREQ 1000000000 > +#define DRA7_DPLL_USB_DEFFREQ 960000000 > > > static struct ti_dt_clk dra7xx_clks[] = { > @@ -328,5 +329,15 @@ int __init dra7xx_dt_clk_init(void) > if (rc) > pr_err("%s: failed to configure GMAC DPLL!\n", __func__); > > + dpll_ck = clk_get_sys(NULL, "dpll_usb_ck"); > + rc = clk_set_rate(dpll_ck, DRA7_DPLL_USB_DEFFREQ); > + if (rc) > + pr_err("%s: failed to configure USB DPLL!\n", __func__); > + > + dpll_ck = clk_get_sys(NULL, "dpll_usb_m2_ck"); > + rc = clk_set_rate(dpll_ck, DRA7_DPLL_USB_DEFFREQ/2); > + if (rc) > + pr_err("%s: failed to set USB_DPLL M2 OUT\n", __func__); > + I would rather see this done using the default-rate mechanism provided here: https://www.mail-archive.com/linux-omap@vger.kernel.org/msg101300.html However, this remains to be commented by Mike whether the patch is okay or not. -Tero > return rc; > } > From mboxrd@z Thu Jan 1 00:00:00 1970 From: t-kristo@ti.com (Tero Kristo) Date: Fri, 7 Mar 2014 15:43:14 +0200 Subject: [PATCH 1/8] CLK: ti: dra7: Initialize USB_DPLL In-Reply-To: <1394197751-28984-2-git-send-email-rogerq@ti.com> References: <1394197751-28984-1-git-send-email-rogerq@ti.com> <1394197751-28984-2-git-send-email-rogerq@ti.com> Message-ID: <5319CCF2.8090902@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 03/07/2014 03:09 PM, Roger Quadros wrote: > USB_DPLL must be initialized and locked at boot so that > USB modules can work. > > Also program USB_DLL_M2 output to half rate. > > CC: Mike Turquette > CC: Tero Kristo > Signed-off-by: Roger Quadros > --- > drivers/clk/ti/clk-7xx.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/clk/ti/clk-7xx.c b/drivers/clk/ti/clk-7xx.c > index 9977653..f89f3c2 100644 > --- a/drivers/clk/ti/clk-7xx.c > +++ b/drivers/clk/ti/clk-7xx.c > @@ -18,6 +18,7 @@ > > #define DRA7_DPLL_ABE_DEFFREQ 361267200 > #define DRA7_DPLL_GMAC_DEFFREQ 1000000000 > +#define DRA7_DPLL_USB_DEFFREQ 960000000 > > > static struct ti_dt_clk dra7xx_clks[] = { > @@ -328,5 +329,15 @@ int __init dra7xx_dt_clk_init(void) > if (rc) > pr_err("%s: failed to configure GMAC DPLL!\n", __func__); > > + dpll_ck = clk_get_sys(NULL, "dpll_usb_ck"); > + rc = clk_set_rate(dpll_ck, DRA7_DPLL_USB_DEFFREQ); > + if (rc) > + pr_err("%s: failed to configure USB DPLL!\n", __func__); > + > + dpll_ck = clk_get_sys(NULL, "dpll_usb_m2_ck"); > + rc = clk_set_rate(dpll_ck, DRA7_DPLL_USB_DEFFREQ/2); > + if (rc) > + pr_err("%s: failed to set USB_DPLL M2 OUT\n", __func__); > + I would rather see this done using the default-rate mechanism provided here: https://www.mail-archive.com/linux-omap at vger.kernel.org/msg101300.html However, this remains to be commented by Mike whether the patch is okay or not. -Tero > return rc; > } > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752981AbaCGNnp (ORCPT ); Fri, 7 Mar 2014 08:43:45 -0500 Received: from bear.ext.ti.com ([192.94.94.41]:57170 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751545AbaCGNnn (ORCPT ); Fri, 7 Mar 2014 08:43:43 -0500 Message-ID: <5319CCF2.8090902@ti.com> Date: Fri, 7 Mar 2014 15:43:14 +0200 From: Tero Kristo User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Roger Quadros , , CC: , , , , , , , Mike Turquette Subject: Re: [PATCH 1/8] CLK: ti: dra7: Initialize USB_DPLL References: <1394197751-28984-1-git-send-email-rogerq@ti.com> <1394197751-28984-2-git-send-email-rogerq@ti.com> In-Reply-To: <1394197751-28984-2-git-send-email-rogerq@ti.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/07/2014 03:09 PM, Roger Quadros wrote: > USB_DPLL must be initialized and locked at boot so that > USB modules can work. > > Also program USB_DLL_M2 output to half rate. > > CC: Mike Turquette > CC: Tero Kristo > Signed-off-by: Roger Quadros > --- > drivers/clk/ti/clk-7xx.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/clk/ti/clk-7xx.c b/drivers/clk/ti/clk-7xx.c > index 9977653..f89f3c2 100644 > --- a/drivers/clk/ti/clk-7xx.c > +++ b/drivers/clk/ti/clk-7xx.c > @@ -18,6 +18,7 @@ > > #define DRA7_DPLL_ABE_DEFFREQ 361267200 > #define DRA7_DPLL_GMAC_DEFFREQ 1000000000 > +#define DRA7_DPLL_USB_DEFFREQ 960000000 > > > static struct ti_dt_clk dra7xx_clks[] = { > @@ -328,5 +329,15 @@ int __init dra7xx_dt_clk_init(void) > if (rc) > pr_err("%s: failed to configure GMAC DPLL!\n", __func__); > > + dpll_ck = clk_get_sys(NULL, "dpll_usb_ck"); > + rc = clk_set_rate(dpll_ck, DRA7_DPLL_USB_DEFFREQ); > + if (rc) > + pr_err("%s: failed to configure USB DPLL!\n", __func__); > + > + dpll_ck = clk_get_sys(NULL, "dpll_usb_m2_ck"); > + rc = clk_set_rate(dpll_ck, DRA7_DPLL_USB_DEFFREQ/2); > + if (rc) > + pr_err("%s: failed to set USB_DPLL M2 OUT\n", __func__); > + I would rather see this done using the default-rate mechanism provided here: https://www.mail-archive.com/linux-omap@vger.kernel.org/msg101300.html However, this remains to be commented by Mike whether the patch is okay or not. -Tero > return rc; > } >