All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Ceresoli <luca@lucaceresoli.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] system/skeleton: add mail group
Date: Fri, 07 Mar 2014 16:04:13 +0100	[thread overview]
Message-ID: <5319DFED.9030706@lucaceresoli.net> (raw)
In-Reply-To: <20140306171331.GC3625@free.fr>

Hi Yann,

Yann E. MORIN wrote:
> Luca, All,
>
> On 2014-03-06 17:54 +0100, Luca Ceresoli spake thusly:
>> ---
>>   system/skeleton/etc/group | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/system/skeleton/etc/group b/system/skeleton/etc/group
>> index 864d1db..85a1fa2 100644
>> --- a/system/skeleton/etc/group
>> +++ b/system/skeleton/etc/group
>> @@ -6,6 +6,7 @@ adm:x:4:
>>   tty:x:5:
>>   disk:x:6:
>>   lp:x:7:
>> +mail:x:8:
>>   kmem:x:9:
>>   wheel:x:10:root
>>   cdrom:x:11:
>
> There is no reason to add the 'mail' group to the default skeleton. If
> it is missing, 'mkuser' is expected to create it (if not, that's a bug.)
>
> So the EXIM_USER in your second patch should be enough.

Technically speaking you're perfectly right.

I just felt the mail group is one of those groups that are supposed to
be used by multiple packages. At least an MTA and a mail server, maybe
a spam filter, a virus scanner... and we might have multiple
alternatives for each of them.

So it looks bad to me to refer to the same group in (potentially) many
packages and not having the group well-defined in "the" group list.

Of course this is my POV, and it's not very strong now that we have such
a small number of mail-related packages in Buildroot...

Oh, following my idea I could as well change:

  define EXIM_USERS
-exim 88 mail 8 * - - - exim
+exim 88 mail -1 * - - - exim
  endef

and your script would get the group ID, right?

-- 
Luca

  reply	other threads:[~2014-03-07 15:04 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-06 16:54 [Buildroot] [PATCH 0/2] Adding exim Luca Ceresoli
2014-03-06 16:54 ` [Buildroot] [PATCH 1/2] system/skeleton: add mail group Luca Ceresoli
2014-03-06 17:13   ` Yann E. MORIN
2014-03-07 15:04     ` Luca Ceresoli [this message]
2014-03-29 16:21       ` Yann E. MORIN
2014-03-29 16:56         ` Sagaert Johan
2014-03-30 13:36           ` Luca Ceresoli
2014-04-05 16:32   ` Thomas Petazzoni
2014-04-05 21:36     ` Luca Ceresoli
2014-03-06 16:54 ` [Buildroot] [PATCH 2/2] exim: new package Luca Ceresoli
2014-03-06 17:38   ` Bernd Kuhls
2014-03-07 14:53     ` Luca Ceresoli
2014-03-07 20:52       ` Bernd Kuhls
2014-04-05 16:35   ` Thomas Petazzoni
2014-04-05 22:11     ` Luca Ceresoli
2014-04-06  8:37       ` Thomas Petazzoni
2014-04-06 15:31         ` Luca Ceresoli
2014-04-09 15:46           ` Luca Ceresoli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5319DFED.9030706@lucaceresoli.net \
    --to=luca@lucaceresoli.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.