Re: [Qemu-devel] [PATCH] mempath: add option to specify minimum huge page size

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1547 bytes --]

On 03/07/2014 08:13 AM, Marcelo Tosatti wrote:
> On Thu, Mar 06, 2014 at 09:21:10PM -0700, Eric Blake wrote:
>> On 03/06/2014 05:40 PM, Marcelo Tosatti wrote:
>>>
>>> Failing initialization in case hugepage path has 
>>> hugepage smaller than specified.
>>>
>>> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
>>>
>>> diff --git a/exec.c b/exec.c
>>> index b69fd29..c95a0f3 100644
>>> --- a/exec.c
>>> +++ b/exec.c
>>
>>>  };
>>>  
>>> +static QemuOptsList qemu_mempath_opts = {
>>> +    .name = "mem-path",
>>
>>> -            case QEMU_OPTION_mempath:
>>> -                mem_path = optarg;
>>> +            case QEMU_OPTION_mempath: {
>>> +                opts = qemu_opts_parse(qemu_find_opts("mem-path"), optarg, 1);
>>
>> Pre-existing, but this is yet another inconsistent naming between C
>> objects and the command line.  If we were consistent, it should be named
>> QEMU_OPTION_mem_path, and qemu_mem_path_options.  (See my recent
>> complaint about other misnamed options:
>> https://lists.gnu.org/archive/html/qemu-devel/2014-03/msg01131.html)
> 
> Hi Erik,

It's Eric, but you're not the first to be affected by finger memory :)

> 
> What is the practical effect of the mismatch?

Harder to grep for things like 'mem.path' (to see both -mem-path strings
and mem_path variable names) when looking for all places in the code
base related to a given command line or QMP spelling.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]