From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Ben Dooks <ben.dooks@codethink.co.uk>, linux-media@vger.kernel.org
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Mauro Carvalho Chehab <m.chehab@samsung.com>,
linux-kernel@vger.kernel.org, magnus.damm@opensource.se,
linux-sh@vger.kernel.org, linux-kernel@lists.codethink.co.uk
Subject: Re: [PATCH 1/5] r8a7790.dtsi: add vin[0-3] nodes
Date: Fri, 07 Mar 2014 15:45:58 +0000 [thread overview]
Message-ID: <5319F7AA.7040305@cogentembedded.com> (raw)
In-Reply-To: <1394197299-17528-2-git-send-email-ben.dooks@codethink.co.uk>
Hello.
On 03/07/2014 04:01 PM, Ben Dooks wrote:
> Add nodes for the four video input channels on the R8A7790.
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
This patch should have been preceded by the VIN driver patch and bindings
description, don't you think?
> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
> index a1e7c39..4c3eafb 100644
> --- a/arch/arm/boot/dts/r8a7790.dtsi
> +++ b/arch/arm/boot/dts/r8a7790.dtsi
> @@ -395,6 +395,38 @@
> status = "disabled";
> };
>
> + vin0: vin@0xe6ef0000 {
ePAPR standard [1] tells us that:
The name of a node should be somewhat generic, reflecting the function of the
device and not its precise programming model.
So, I would suggest something like "video". And remove "0x" from the
address part of the node name please.
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Ben Dooks <ben.dooks@codethink.co.uk>, linux-media@vger.kernel.org
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Mauro Carvalho Chehab <m.chehab@samsung.com>,
linux-kernel@vger.kernel.org, magnus.damm@opensource.se,
linux-sh@vger.kernel.org, linux-kernel@lists.codethink.co.uk
Subject: Re: [PATCH 1/5] r8a7790.dtsi: add vin[0-3] nodes
Date: Fri, 07 Mar 2014 19:45:30 +0300 [thread overview]
Message-ID: <5319F7AA.7040305@cogentembedded.com> (raw)
In-Reply-To: <1394197299-17528-2-git-send-email-ben.dooks@codethink.co.uk>
Hello.
On 03/07/2014 04:01 PM, Ben Dooks wrote:
> Add nodes for the four video input channels on the R8A7790.
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
This patch should have been preceded by the VIN driver patch and bindings
description, don't you think?
> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
> index a1e7c39..4c3eafb 100644
> --- a/arch/arm/boot/dts/r8a7790.dtsi
> +++ b/arch/arm/boot/dts/r8a7790.dtsi
> @@ -395,6 +395,38 @@
> status = "disabled";
> };
>
> + vin0: vin@0xe6ef0000 {
ePAPR standard [1] tells us that:
The name of a node should be somewhat generic, reflecting the function of the
device and not its precise programming model.
So, I would suggest something like "video". And remove "0x" from the
address part of the node name please.
WBR, Sergei
next prev parent reply other threads:[~2014-03-07 15:45 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-07 13:01 soc_camera rcar_vin support for device-tree binding Ben Dooks
2014-03-07 13:01 ` Ben Dooks
2014-03-07 13:01 ` [PATCH 1/5] r8a7790.dtsi: add vin[0-3] nodes Ben Dooks
2014-03-07 13:01 ` Ben Dooks
2014-03-07 15:45 ` Sergei Shtylyov [this message]
2014-03-07 16:45 ` Sergei Shtylyov
2014-03-07 15:54 ` Ben Dooks
2014-03-13 1:56 ` Simon Horman
2014-03-13 1:56 ` Simon Horman
2014-03-07 13:01 ` [PATCH 2/5] ARM: lager: add vin1 node Ben Dooks
2014-03-07 13:01 ` Ben Dooks
2014-03-07 15:51 ` Sergei Shtylyov
2014-03-07 16:50 ` Sergei Shtylyov
2014-03-07 16:06 ` Ben Dooks
2014-03-07 16:22 ` Sergei Shtylyov
2014-03-07 17:22 ` Sergei Shtylyov
2014-03-13 1:55 ` Simon Horman
2014-03-13 1:55 ` Simon Horman
2014-03-07 13:01 ` [PATCH 3/5] media: soc_camera: rcar_vin: Add support for 10-bit YUV cameras Ben Dooks
2014-03-07 13:01 ` Ben Dooks
2014-03-07 13:01 ` [PATCH 4/5] rcar_vin: copy flags from pdata Ben Dooks
2014-03-07 13:01 ` Ben Dooks
2014-03-07 13:01 ` [PATCH 5/5] rcar_vin: add devicetree support Ben Dooks
2014-03-07 13:01 ` Ben Dooks
2014-03-07 13:15 ` Geert Uytterhoeven
2014-03-07 13:15 ` Geert Uytterhoeven
2014-03-07 16:20 ` Sergei Shtylyov
2014-03-07 17:19 ` Sergei Shtylyov
2014-03-08 11:07 ` Guennadi Liakhovetski
2014-03-08 11:07 ` Guennadi Liakhovetski
2014-03-30 21:04 ` Guennadi Liakhovetski
2014-03-30 21:04 ` Guennadi Liakhovetski
2014-03-30 21:13 ` Ben Dooks
2014-03-30 21:13 ` Ben Dooks
2014-03-30 21:17 ` Guennadi Liakhovetski
2014-03-30 21:17 ` Guennadi Liakhovetski
2014-03-30 21:28 ` Ben Dooks
2014-03-30 21:28 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5319F7AA.7040305@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=ben.dooks@codethink.co.uk \
--cc=g.liakhovetski@gmx.de \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=magnus.damm@opensource.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.