From: Paolo Bonzini <pbonzini@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>,
Gleb Natapov <gleb@kernel.org>,
Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm <kvm@vger.kernel.org>
Subject: Re: [PATCH v3 1/3] KVM: nVMX: Rework interception of IRQs and NMIs
Date: Fri, 07 Mar 2014 20:45:20 +0100 [thread overview]
Message-ID: <531A21D0.8030502@redhat.com> (raw)
In-Reply-To: <531A0F71.40507@siemens.com>
Il 07/03/2014 19:26, Jan Kiszka ha scritto:
>> > Reading through my code again, I'm now wondering why I added
>> > check_nested_events to both inject_pending_event and vcpu_enter_guest.
>> > The former seems redundant, only vcpu_enter_guest calls
>> > inject_pending_event. I guess I forgot a cleanup here.
> Nah, it's not redundant, we need to check for potential L2->L2 switches
> *before* trying deliver events to L2.
Yeah, and after the call in inject_pending_event you can similarly have
an "else if" since vmx_nmi/interrupt_allowed will check
nested_run_pending and never return true.
> But think I can (and probably
> should) get rid of the second test in vcpu_enter_guest.
If so inject_pending_event would return true to request an immediate
exit, right?
Paolo
next prev parent reply other threads:[~2014-03-07 19:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-06 17:33 [PATCH v3 0/3] KVM: x86: Pending nVMX fixes Jan Kiszka
2014-03-06 17:33 ` [PATCH v3 1/3] KVM: nVMX: Rework interception of IRQs and NMIs Jan Kiszka
2014-03-07 15:44 ` Paolo Bonzini
2014-03-07 16:29 ` Jan Kiszka
2014-03-07 16:46 ` Paolo Bonzini
2014-03-07 17:28 ` Jan Kiszka
2014-03-07 18:19 ` Jan Kiszka
2014-03-07 18:24 ` Paolo Bonzini
2014-03-07 18:26 ` Jan Kiszka
2014-03-07 19:45 ` Paolo Bonzini [this message]
2014-03-06 17:33 ` [PATCH v3 2/3] KVM: nVMX: Fully emulate preemption timer Jan Kiszka
2014-03-07 17:20 ` Marcelo Tosatti
2014-03-07 17:24 ` Paolo Bonzini
2014-03-06 17:33 ` [PATCH v3 3/3] KVM: nVMX: Do not inject NMI vmexits when L2 has a pending interrupt Jan Kiszka
2014-03-06 17:41 ` [PATCH v3 0/3] KVM: x86: Pending nVMX fixes Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531A21D0.8030502@redhat.com \
--to=pbonzini@redhat.com \
--cc=gleb@kernel.org \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.