From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49812) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WM0i7-0000rp-9J for qemu-devel@nongnu.org; Fri, 07 Mar 2014 14:45:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WM0hx-0007li-MU for qemu-devel@nongnu.org; Fri, 07 Mar 2014 14:45:35 -0500 Received: from cantor2.suse.de ([195.135.220.15]:45258 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WM0hx-0007lZ-Eo for qemu-devel@nongnu.org; Fri, 07 Mar 2014 14:45:25 -0500 Message-ID: <531A21D2.9010500@suse.de> Date: Fri, 07 Mar 2014 20:45:22 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1394020420-17576-1-git-send-email-kraxel@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL v4 00/38] rework input handling, sdl2 support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , Gerd Hoffmann Cc: QEMU Developers , Stefano Stabellini Am 07.03.2014 20:23, schrieb Peter Maydell: > On 5 March 2014 11:53, Gerd Hoffmann wrote: >> Hi, >> >> The input layer moves to a model modeled roughly after the linux >> event layer. It also uses qapi to create all the data types needed. >> First, because it is convinient to have all the support code generated= , >> and also to make it easier to integrate with qmp some day. >> >> Porting work has only be done on the UI side so far. Input device >> emulation is still to be done. >> >> Pull v4 rebase, fix build failure. >> Pull v3 combines all sdl2 changes into a single patch. >> Pull v2 fixes minor issues and adds missing sign-offs. >=20 > Applied; thanks for doing all those respins. Still problems despite at v4 already: CC hw/display/xenfb.o /home/andreas/QEMU/qemu/hw/display/xenfb.c: In function =E2=80=98xen_init= _display=E2=80=99: /home/andreas/QEMU/qemu/hw/display/xenfb.c:995:5: error: passing argument 2 of =E2=80=98graphic_console_init=E2=80=99 makes integer from p= ointer without a cast [-Werror] fb->c.con =3D graphic_console_init(NULL, &xenfb_ops, fb); ^ In file included from /home/andreas/QEMU/qemu/hw/display/xenfb.c:39:0: /home/andreas/QEMU/qemu/include/ui/console.h:282:14: note: expected =E2=80=98uint32_t=E2=80=99 but argument is of type =E2=80=98const struct = GraphicHwOps *=E2=80=99 QemuConsole *graphic_console_init(DeviceState *dev, uint32_t head, ^ /home/andreas/QEMU/qemu/hw/display/xenfb.c:995:5: error: passing argument 3 of =E2=80=98graphic_console_init=E2=80=99 from incompatible po= inter type [-Werror] fb->c.con =3D graphic_console_init(NULL, &xenfb_ops, fb); ^ In file included from /home/andreas/QEMU/qemu/hw/display/xenfb.c:39:0: /home/andreas/QEMU/qemu/include/ui/console.h:282:14: note: expected =E2=80=98const struct GraphicHwOps *=E2=80=99 but argument is of type =E2= =80=98struct XenFB *=E2=80=99 QemuConsole *graphic_console_init(DeviceState *dev, uint32_t head, ^ /home/andreas/QEMU/qemu/hw/display/xenfb.c:995:5: error: too few arguments to function =E2=80=98graphic_console_init=E2=80=99 fb->c.con =3D graphic_console_init(NULL, &xenfb_ops, fb); ^ In file included from /home/andreas/QEMU/qemu/hw/display/xenfb.c:39:0: /home/andreas/QEMU/qemu/include/ui/console.h:282:14: note: declared here QemuConsole *graphic_console_init(DeviceState *dev, uint32_t head, ^ cc1: all warnings being treated as errors make: *** [hw/display/xenfb.o] Fehler 1 Will try to cook up a patch later (inserting "0, " as seen elsewhere?) if no one beats me to it. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg