All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@linux.intel.com>
To: Dave Jones <davej@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Fengguang Wu <fengguang.wu@intel.com>,
	Ingo Molnar <mingo@kernel.org>,
	Yinghai Lu <yhlu.kernel@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [qemu64,+smep,+smap] WARNING: CPU: 1 PID: 0 at arch/x86/kernel/cpu/amd.c:220 init_amd()
Date: Fri, 07 Mar 2014 14:11:50 -0800	[thread overview]
Message-ID: <531A4426.30504@linux.intel.com> (raw)
In-Reply-To: <20140307220655.GA580@redhat.com>

On 03/07/2014 02:06 PM, Dave Jones wrote:
> On Fri, Mar 07, 2014 at 10:38:56PM +0100, Borislav Petkov wrote:
> 
>  > * Another option would be if we change the f/m/s of "qemu64" so that
>  > the test doesn't fire.
>  > 
>  > What also makes me wonder is why is this thing even called qemu64?? AMD
>  > family 6 was 32-bit only CPUs so 64 is kinda wrong IMO. I mean, the
>  > kernel code is in "ifdef CONFIG_X86_32" block so "qemu64" is patently
>  > wrong naming.
> 
> Additionally, fam:6 model:6 stepping 3 never existed in the real world afaict.
> I used to keep x86info's stepping db pretty up to date, and that only has knowledge
> of stepping 1 & 2.[*]  Modelling qemu on something from the real world might be
> a better idea than inventing new special cases.
> 
>  > Oh, and the thing has CPUID_EXT2_LM which is also a WTH moment for me.
>  > Paolo, what's going on here?
> 
> Yeah, this is a mess, there should be no family < 0xf with LM set.
> 
> 	Dave

For AMD, at least.  Intel obviously have a bunch of chips with family ==
6 and LM.

Perhaps Fengguang should switch from "qemu64,+smep,+smap" to something
like "Haswell,+smep,+smap" instead for the time being at least?

	-hpa


  reply	other threads:[~2014-03-07 22:12 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-07  1:58 [qemu64,+smep,+smap] WARNING: CPU: 1 PID: 0 at arch/x86/kernel/cpu/amd.c:220 init_amd() Fengguang Wu
2014-03-07  5:03 ` H. Peter Anvin
2014-03-07  5:50   ` Fengguang Wu
2014-03-07 18:56     ` H. Peter Anvin
2014-03-07 19:10       ` Dave Jones
2014-03-07 21:01         ` H. Peter Anvin
2014-03-07 21:38           ` Borislav Petkov
2014-03-07 22:06             ` Dave Jones
2014-03-07 22:11               ` H. Peter Anvin [this message]
2014-03-07 22:22                 ` Dave Jones
2014-03-07 22:27                 ` Fengguang Wu
2014-03-07 22:34                   ` Borislav Petkov
2014-03-07 22:20               ` Borislav Petkov
2014-03-07 22:27                 ` Dave Jones
2014-03-07 22:39                   ` Borislav Petkov
2014-03-09 18:07             ` Paolo Bonzini
2014-03-09 18:50               ` Borislav Petkov
2014-03-10  0:01               ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=531A4426.30504@linux.intel.com \
    --to=hpa@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=davej@redhat.com \
    --cc=fengguang.wu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=yhlu.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.