From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50725)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WMgeJ-00048G-MS
	for qemu-devel@nongnu.org; Sun, 09 Mar 2014 12:32:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WMgeC-000273-DA
	for qemu-devel@nongnu.org; Sun, 09 Mar 2014 12:32:27 -0400
Received: from cantor2.suse.de ([195.135.220.15]:36266 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WMgeC-00026x-7N
	for qemu-devel@nongnu.org; Sun, 09 Mar 2014 12:32:20 -0400
Message-ID: <531C9791.10207@suse.de>
Date: Sun, 09 Mar 2014 17:32:17 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1394304438-14848-1-git-send-email-l@dorileo.org>
In-Reply-To: <1394304438-14848-1-git-send-email-l@dorileo.org>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH RFC 0/2] qemu-arg: general purpose argument
 parser
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Leandro Dorileo <l@dorileo.org>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Fam Zheng <famz@redhat.com>, Stefan Weil <sw@weilnetz.de>, Michael Tokarev <mjt@tls.msk.ru>, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Laszlo Ersek <lersek@redhat.com>, Peter Lieven <pl@kamp.de>

Am 08.03.2014 19:47, schrieb Leandro Dorileo:
> The following patchset introduces a general purpose argument parser and=
 migrates
> qemu-img to make use of it. qemu-img is just the first user of it, if w=
e see a
> good feedback here I move forward and migrate all the other possible us=
ers.

Why? :) You forgot to describe what's wrong with the current
infrastructure, how your approach is different and what the benefit is.

Regards,
Andreas

> Leandro Dorileo (2):
>   qemu-arg: introduce a general purpose argument parser
>   qemu-img: migrate to use qemu-arg
>=20
>  .gitignore              |    1 +
>  Makefile                |   12 +-
>  include/qemu/qemu-arg.h |  287 ++++++++++++
>  qemu-img-cmds.hx        |   77 ---
>  qemu-img-descs.h        |  128 +++++
>  qemu-img.c              | 1184 ++++++++++++++++-----------------------=
--------
>  util/Makefile.objs      |    1 +
>  util/qemu-arg.c         |  887 +++++++++++++++++++++++++++++++++++
>  8 files changed, 1706 insertions(+), 871 deletions(-)
>  create mode 100644 include/qemu/qemu-arg.h
>  delete mode 100644 qemu-img-cmds.hx
>  create mode 100644 qemu-img-descs.h
>  create mode 100644 util/qemu-arg.c
>=20


--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg