From: Lars-Peter Clausen <lars@metafoo.de>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Jarkko Nikula <jarkko.nikula@bitmer.com>,
Grazvydas Ignotas <notasas@gmail.com>
Subject: Re: [PATCH 1/3] ASoC: omap-abe-twl6040: No need to register DMIC routes seperatly
Date: Mon, 10 Mar 2014 09:18:50 +0100 [thread overview]
Message-ID: <531D756A.6000505@metafoo.de> (raw)
In-Reply-To: <531D7427.5020006@ti.com>
On 03/10/2014 09:13 AM, Peter Ujfalusi wrote:
> Hi,
>
> On 03/08/2014 08:16 PM, Lars-Peter Clausen wrote:
>> When using table based DAPM setup there is no need to register DAPM elements for
>> different sub-components separately. The widgets will be registered before the
>> first sub-component is initialized, the routes are only added after the last
>> sub-component has been initialized, meaning everything will be available when it
>> is needed.
>
> The reason why we add the DMIC routes in the way we do is that not all boards
> have DMIC in use. PandaBoards does not have DMIC while SDP/Blaze have. On
> PandaBoard we do not register the dmic dai link so the widgets are not going
> to be added and also the dmic DAI and codec will be not loaded on PandaBoards.
> I think this will cause some warning because of missing "DMic" widget?
>
Hm, ok, missed that part. Makes sense. I'll respin the patch to just use the
card's DAPM context when registering the DMIC DAPM routes.
- Lars
next prev parent reply other threads:[~2014-03-10 8:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-08 18:16 [PATCH 1/3] ASoC: omap-abe-twl6040: No need to register DMIC routes seperatly Lars-Peter Clausen
2014-03-08 18:16 ` [PATCH 2/3] ASoC: rx51: Convert to table based control and DAPM setup Lars-Peter Clausen
2014-03-08 18:16 ` [PATCH 3/3] ASoC: omap3pandora: Convert to table based " Lars-Peter Clausen
2014-03-10 8:13 ` [PATCH 1/3] ASoC: omap-abe-twl6040: No need to register DMIC routes seperatly Peter Ujfalusi
2014-03-10 8:18 ` Lars-Peter Clausen [this message]
2014-03-10 9:12 ` Mark Brown
2014-03-10 9:24 ` Lars-Peter Clausen
2014-03-10 10:10 ` Mark Brown
2014-03-10 10:27 ` Lars-Peter Clausen
2014-03-10 11:05 ` Mark Brown
2014-03-10 11:29 ` Lars-Peter Clausen
2014-03-10 12:09 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531D756A.6000505@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jarkko.nikula@bitmer.com \
--cc=lgirdwood@gmail.com \
--cc=notasas@gmail.com \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.