From: Jyri Sarha <jsarha-l0cyMroinI0@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
liam.r.girdwood-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
peter.ujfalusi-l0cyMroinI0@public.gmane.org,
detheridge-l0cyMroinI0@public.gmane.org,
bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH v2 1/4] ASoC: tlv320aic31xx: Add basic codec driver implementation
Date: Mon, 10 Mar 2014 10:47:15 +0200 [thread overview]
Message-ID: <531D7C13.4050007@ti.com> (raw)
In-Reply-To: <20140309081229.GM28112-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
On 03/09/2014 10:12 AM, Mark Brown wrote:
> On Fri, Mar 07, 2014 at 02:53:15PM +0200, Jyri Sarha wrote:
>> On 03/05/2014 03:55 AM, Mark Brown wrote:
>
>>>> + /* Mic Bias */
>>>> + SND_SOC_DAPM_SUPPLY("Mic Bias", SND_SOC_NOPM, 0, 0, mic_bias_event,
>>>> + SND_SOC_DAPM_POST_PMU | SND_SOC_DAPM_PRE_PMD),
>
>>> The idiomatic thing would be to use the pin name.
>
>> In this case the mic bias comes out of the chip trough a separate
>> pin and it is up to board designer to connect it with any (or all)
>> of the three mic pins.
>
> Yes, exactly - you should be using the name of the pin that supplies the
> bias. This is how essentially all microphone biases work.
>
Changed widget name from "Mic Bias" to "MICBIAS".
BR,
Jyri
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-03-10 8:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 13:54 [PATCH v2 0/4] AM43xx-ePOS-EVM audio support with TLV320AIC31XX driver Jyri Sarha
2014-03-04 13:54 ` [PATCH v2 2/4] ASoC: davinci-evm: Add AM43xx-EPOS-EVM audio support Jyri Sarha
2014-03-04 14:12 ` Lars-Peter Clausen
[not found] ` <5315DF41.1090302-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2014-03-04 15:40 ` [alsa-devel] " Jyri Sarha
2014-03-04 15:43 ` [PATCH v3] " Jyri Sarha
2014-03-05 1:42 ` Mark Brown
2014-03-07 12:45 ` Jyri Sarha
2014-03-09 8:11 ` Mark Brown
2014-03-10 10:49 ` Jyri Sarha
2014-03-10 11:09 ` Mark Brown
2014-03-10 11:31 ` Peter Ujfalusi
2014-03-10 11:57 ` Mark Brown
[not found] ` <cover.1393941102.git.jsarha-l0cyMroinI0@public.gmane.org>
2014-03-04 13:54 ` [PATCH v2 1/4] ASoC: tlv320aic31xx: Add basic codec driver implementation Jyri Sarha
[not found] ` <ba9718f573ca9195c80075a15fe114e0d4557da0.1393941102.git.jsarha-l0cyMroinI0@public.gmane.org>
2014-03-05 1:55 ` Mark Brown
[not found] ` <20140305015501.GS13126-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-03-07 12:53 ` Jyri Sarha
[not found] ` <5319C13B.4090101-l0cyMroinI0@public.gmane.org>
2014-03-09 8:12 ` Mark Brown
[not found] ` <20140309081229.GM28112-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-03-10 8:47 ` Jyri Sarha [this message]
2014-03-04 13:54 ` [PATCH v2 3/4] ASoC: davinci: Add SND_AM43XX_SOC_EPOS_EVM build option Jyri Sarha
2014-03-04 13:54 ` [PATCH v2 4/4] ASoC: tlv320aic32x4: Sort Makefile in alphabetic order Jyri Sarha
[not found] ` <80b0f9ecd29b8bfb52fed22a0ca059591f89683d.1393941102.git.jsarha-l0cyMroinI0@public.gmane.org>
2014-03-05 3:28 ` Mark Brown
[not found] ` <20140305032808.GW13126-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-03-05 7:14 ` Jyri Sarha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531D7C13.4050007@ti.com \
--to=jsarha-l0cymroini0@public.gmane.org \
--cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
--cc=bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=detheridge-l0cyMroinI0@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=liam.r.girdwood-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=peter.ujfalusi-l0cyMroinI0@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.