From: Jyri Sarha <jsarha@ti.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"peter.ujfalusi@ti.com" <peter.ujfalusi@ti.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"liam.r.girdwood@linux.intel.com"
<liam.r.girdwood@linux.intel.com>,
"bcousson@baylibre.com" <bcousson@baylibre.com>,
"detheridge@ti.com" <detheridge@ti.com>
Subject: Re: [PATCH v4] ASoC: tlv320aic31xx: Add basic codec driver implementation
Date: Mon, 10 Mar 2014 15:15:56 +0200 [thread overview]
Message-ID: <531DBB0C.4020205@ti.com> (raw)
In-Reply-To: <20140310120938.GJ14999@e106331-lin.cambridge.arm.com>
On 03/10/2014 02:09 PM, Mark Rutland wrote:
> On Mon, Mar 10, 2014 at 08:52:21AM +0000, Jyri Sarha wrote:
>> This commit adds a bare bones driver support for TLV320AIC31XX family
>> audio codecs. The driver adds basic stereo playback trough headphone
>> and speaker outputs and mono capture trough microphone inputs.
>>
>> The driver is currently missing support at least for mini DSP features
>> and jack detection. I have tested the driver only on TLV320AIC3111,
>> but based on the data sheets TLV320AIC3100, TLV320AIC3110, and
>> TLV320AIC3120 should work Ok too.
>>
>> The base for the implementation was taken from:
>> git@gitorious.org:ti-codecs/ti-codecs.git ajitk/topics/k3.10.1-aic31xx
>> -branch at commit 77504eba0294764e9e63b4a0c696b44db187cd13.
>>
>> Signed-off-by: Jyri Sarha <jsarha@ti.com>
>> ---
>> .../devicetree/bindings/sound/tlv320aic31xx.txt | 61 +
>> include/dt-bindings/sound/tlv320aic31xx-micbias.h | 9 +
>> sound/soc/codecs/Kconfig | 4 +
>> sound/soc/codecs/Makefile | 2 +
>> sound/soc/codecs/tlv320aic31xx.c | 1343 ++++++++++++++++++++
>> sound/soc/codecs/tlv320aic31xx.h | 258 ++++
>> 6 files changed, 1677 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/sound/tlv320aic31xx.txt
>> create mode 100644 include/dt-bindings/sound/tlv320aic31xx-micbias.h
>> create mode 100644 sound/soc/codecs/tlv320aic31xx.c
>> create mode 100644 sound/soc/codecs/tlv320aic31xx.h
>>
>> diff --git a/Documentation/devicetree/bindings/sound/tlv320aic31xx.txt b/Documentation/devicetree/bindings/sound/tlv320aic31xx.txt
>> new file mode 100644
>> index 0000000..0109df1
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/sound/tlv320aic31xx.txt
>> @@ -0,0 +1,61 @@
>> +Texas Instruments - tlv320aic31xx Codec module
>> +
>> +The tlv320aic31xx serial control bus communicates through I2C protocols
>> +
>> +Required properties:
>> +
>> +- compatible - "string" - One of:
>> + "ti,tlv320aic310x" - Generic TLV320AIC31xx with mono speaker amp
>> + "ti,tlv320aic311x" - Generic TLV320AIC31xx with stereo speaker amp
>> + "ti,tlv320aic3100" - TLV320AIC3100 (mono speaker amp, no MiniDSP)
>> + "ti,tlv320aic3110" - TLV320AIC3110 (stereo speaker amp, no MiniDSP)
>> + "ti,tlv320aic3120" - TLV320AIC3120 (mono speaker amp, MiniDSP)
>> + "ti,tlv320aic3111" - TLV320AIC3111 (stereo speaker amp, MiniDSP)
>> +
>> +- reg - <int> - I2C slave address
>> +
>> +
>> +Optional properties:
>> +
>> +- gpio-reset - gpio pin number used for codec reset
>
> I believe calling this reset-gpio would be more in keeping with the gpio
> bindings.
>
> I'd get rid of "pin number" from the description. GPIOs are referred to
> with phandle + gpio-specifier pairs, and this makes it sound like a
> single integer value.
>
>> +- ai31xx-micbias-vg - MicBias Voltage setting
>
> This name is a bit terse. Perhaps s/vg/voltage/ ?
>
This parameter name is symmetric to already existing "ai3x-micbias-vg"
in tlv320aic3x driver. Well... that is not a very good reason for not to
change it. I'll change that to the next version of the patch.
>> + 0 or MICBIAS_OFF - MICBIAS output it not powered
>
> s/it/is/
>
To be fixed.
Best regards,
Jyri
next prev parent reply other threads:[~2014-03-10 13:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 8:52 [PATCH v4] AM43xx-ePOS-EVM audio support with TLV320AIC31XX driver Jyri Sarha
2014-03-10 8:52 ` [PATCH v4] ASoC: tlv320aic31xx: Add basic codec driver implementation Jyri Sarha
2014-03-10 9:39 ` Lokesh Vutla
2014-03-10 9:45 ` Mark Brown
2014-03-10 12:09 ` Mark Rutland
2014-03-10 12:11 ` Mark Brown
2014-03-10 13:15 ` Jyri Sarha [this message]
2014-03-10 13:31 ` Mark Rutland
2014-03-10 12:58 ` Mark Brown
[not found] ` <20140310125848.GI28112-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-03-10 13:25 ` Jyri Sarha
2014-03-10 15:47 ` Mark Brown
2014-03-10 16:05 ` Jyri Sarha
2014-03-10 19:23 ` Jyri Sarha
2014-03-10 9:13 ` [PATCH v4] AM43xx-ePOS-EVM audio support with TLV320AIC31XX driver Mark Brown
2014-03-10 9:26 ` Jyri Sarha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531DBB0C.4020205@ti.com \
--to=jsarha@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=bcousson@baylibre.com \
--cc=broonie@kernel.org \
--cc=detheridge@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.