Re: [Qemu-devel] [PATCH] net: L2TPv3 transport

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1751 bytes --]

On 03/10/2014 05:31 AM, anton.ivanov@kot-begemot.co.uk wrote:
> From: Anton Ivanov <antivano@cisco.com>

When sending revisions of a patch sent earlier, be sure to include
'PATCHv2' (or higher, as appropriate) in the subject,...

> 
> This tranport allows to connect a qemu nic to a static Ethernet
> over L2TPv3 tunnel. The transport supports all options present
> in the linux kernel implementation. It allows qemu to connect
> to any linux host running kernel 3.3+, most routers and network
> 
> Signed-off-by: Anton Ivanov <antivano@cisco.com>
> ---

...and describe what changed from v1 after the --- separator.  That way,
earlier reviewers will know what differences to look for, instead of
assuming it is a brand new patch.

> +++ b/qapi-schema.json
> @@ -2940,6 +2940,60 @@
>      '*localaddr': 'str',
>      '*udp':       'str' } }
>  
> +# @NetdevL2TPv3Options

Missing a ## line prior to the struct name.

> +# @pincounter: #optional pin sequence counter to zero - workaround for buggy implementations or networks with packet reorder

Super long line.  Please wrap at 80 columns.

> +#
> +# @txcookie: #optional 32 or 64 bit transmit cookie
> +#
> +# @rxcookie: #optional 32 or 64 bit receive cookie
> +#
> +# @txsession: 32 bit transmit session
> +#
> +# @rxsession: 32 bit receive session - if not specified set to the same value as transmit
> +#
> +# @optional: additional offset - allows the insertion of additional application-specific data before the packet payload

Another long line.  Also, you don't have a variable named 'optional';
you probably meant '@offset: #optional'.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]