From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58079) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WN5et-0002JJ-HD for qemu-devel@nongnu.org; Mon, 10 Mar 2014 15:14:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WN5em-0004Vn-JR for qemu-devel@nongnu.org; Mon, 10 Mar 2014 15:14:43 -0400 Received: from alln-iport-1.cisco.com ([173.37.142.88]:12223) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WN5em-0004Vj-2P for qemu-devel@nongnu.org; Mon, 10 Mar 2014 15:14:36 -0400 From: "Anton Ivanov (antivano)" Date: Mon, 10 Mar 2014 19:14:34 +0000 Message-ID: <531E0F0A.8030708@cisco.com> References: <1394028740-710822-1-git-send-email-anton.ivanov@kot-begemot.co.uk> <20140306094428.GB23172@stefanha-thinkpad.redhat.com> <531C9F87.4000105@kot-begemot.co.uk> <20140310083531.GA24112@stefanha-thinkpad.redhat.com> <531D7C7D.4030300@kot-begemot.co.uk> <20140310180438.GG32400@stefanha-thinkpad.redhat.com> In-Reply-To: <20140310180438.GG32400@stefanha-thinkpad.redhat.com> Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] New feature - RFC3931 L2TPv3 network transport using static Ethernet over L2TPv3 tunnels List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: "pbonzini@redhat.com" , "afaerber@suse.de" , Anton Ivanov , Stefan Hajnoczi , "qemu-devel@nongnu.org" On 10/03/14 18:04, Stefan Hajnoczi wrote: > On Mon, Mar 10, 2014 at 08:49:01AM +0000, Anton Ivanov wrote: >> You are correct. My test is wrong. >> >> However, the result is the same - it wants a non-zero proto there. >> >> $ sudo ./gaitest >> src ai_family 2 ai_socketype 3 ai_protocol 0 >> socket creation failed, errno =3D 93 > You are right! > > I got confused with Linux net/l2tp/l2tp_ip.c driver which handles > socket(AF_INET, SOCK_DGRAM, IPPROTO_L2TP). But that has nothing to do > with this raw socket code which needs to do socket(AF_INET, SOCK_RAW, > IPPROTO_L2TP). > > IPPROTO_L2TP *is* needed after all since SOCK_RAW wants > to know the IP protocol number so it can receive incoming packets. > We're not trying to capture all IP packets, just the L2TP ones. > > So I'm happy again with the code. OK. In that case I will fix the few remaining issues with the interface file, mark that as v5 and resubmit tomorrow. I think I have addressed all other comments. Best Regards, A. > > Stefan