From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45703) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WN8n8-0005ib-Kl for qemu-devel@nongnu.org; Mon, 10 Mar 2014 18:35:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WN8n2-0002Op-Ol for qemu-devel@nongnu.org; Mon, 10 Mar 2014 18:35:26 -0400 Received: from mail-pd0-f178.google.com ([209.85.192.178]:39038) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WN8n2-0002Oc-Js for qemu-devel@nongnu.org; Mon, 10 Mar 2014 18:35:20 -0400 Received: by mail-pd0-f178.google.com with SMTP id x10so7702121pdj.9 for ; Mon, 10 Mar 2014 15:35:19 -0700 (PDT) Message-ID: <531E3E22.3090700@ozlabs.ru> Date: Tue, 11 Mar 2014 09:35:14 +1100 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <5315C65F.6040103@redhat.com> <1393946096-27403-1-git-send-email-aik@ozlabs.ru> <20140310171729.GC11308@grmbl.mre> In-Reply-To: <20140310171729.GC11308@grmbl.mre> Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3] migration: add more traces List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amit Shah Cc: Paolo Bonzini , qemu-devel@nongnu.org, Juan Quintela On 03/11/2014 04:17 AM, Amit Shah wrote: > On (Wed) 05 Mar 2014 [02:14:56], Alexey Kardashevskiy wrote: >> This replaces DPRINTF macro with tracepoints. >> >> This moves some messages from migration.c to savevm.c. >> >> This adds tracepoint to signal about fileds failed to migrate. >> >> Signed-off-by: Alexey Kardashevskiy >> --- >> >> This is v3. Should I repost the whole thing or just "3/3 v3" is ok? Thanks! > > This broke the build on windows: > > http://news.gmane.org/find-root.php?message_id=CAFEAcA%5fEa72JTVLJ3Z%2dzUtoe8vg%2bjh8R96mNW2c2x2Mx%5fj%2bFwg%40mail.gmail.com > > Please fix. I am sorry but how? Is it msvc? Is it mingw? Or replace with %02x:%02x:%02x:%02x:%02x:%02x? -- Alexey