From: Or Gerlitz <ogerlitz@mellanox.com>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
Dennis.Cullison@Teradata.com
Cc: stgt@vger.kernel.org
Subject: Re: spc: Support NAA IEEE Registered Extended field in VPD page 0x83
Date: Tue, 11 Mar 2014 08:14:05 +0200 [thread overview]
Message-ID: <531EA9AD.2050400@mellanox.com> (raw)
In-Reply-To: <20140308.214054.1305564732068200109.fujita.tomonori@lab.ntt.co.jp>
On 08/03/2014 14:40, FUJITA Tomonori wrote:
>> @@ -160,6 +166,24 @@ static void update_vpd_83(struct scsi_lu *lu, void *id)
>> >
>> > put_unaligned_be64(lu->attrs.numeric_id, data);
>> > data[0] |= NAA_LOCAL << 4;
>> >+
>> >+ data += NAA_DESG_LEN;
>> >+ data[0] = INQ_CODE_BIN;
>> >+ data[1] = DESG_NAA;
>> >+ data[3] = NAA_DESG_LEN_EXTD;
>> >+ data += DESG_HDR_LEN;
>> >+ while (*id_str) {
>> >+ subs[0] = *id_str++;
>> >+ c = a >> 60;
>> >+ a <<= 4;
>> >+ b <<= 4;
>> >+ b |= c;
>> >+ a |= strtoul(subs, NULL, 16);
> Can you please add comments to explan what the above code is supposed
> to do? Also the code works on architecture where long is 32bits?
>
>
sure, Dennis will look into this, he said this is going to take few more
days, so we'll let you know.
Or.
prev parent reply other threads:[~2014-03-11 6:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-25 12:54 spc: Support NAA IEEE Registered Extended field in VPD page 0x83 Or Gerlitz
2014-03-03 17:14 ` Or Gerlitz
2014-03-03 22:28 ` FUJITA Tomonori
2014-03-04 8:48 ` Or Gerlitz
2014-03-04 17:08 ` Cullison, Dennis
2014-03-05 20:52 ` Or Gerlitz
2014-03-08 12:40 ` FUJITA Tomonori
2014-03-11 6:14 ` Or Gerlitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531EA9AD.2050400@mellanox.com \
--to=ogerlitz@mellanox.com \
--cc=Dennis.Cullison@Teradata.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=stgt@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.