All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Yang <liezhi.yang@windriver.com>
To: Paul Eggleton <paul.eggleton@linux.intel.com>
Cc: Jussi Laako <jussi@sonarnerd.net>,
	"openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>
Subject: Re: [dora]Re: Failure in license.bbclass
Date: Tue, 11 Mar 2014 18:40:34 +0800	[thread overview]
Message-ID: <531EE822.7070201@windriver.com> (raw)
In-Reply-To: <2472430.vmDQzt5qix@peggleto-mobl5.ger.corp.intel.com>

On 03/11/2014 06:02 PM, Paul Eggleton wrote:
> Hi Hongxu,
>
> The person you need to CC is Robert Yang since he maintains the dora branch.
> FWIW I hadn't anticipated this patch being backported, but I guess if
> functionality now in dora relies upon it we have no choice :(
>

I'm sorry to say that it seems that we can't backport this patch since
we need at least the following patches, it is not a good idea to backport
it:

d69931d scripts/oe-pkgdata-util: fix global name 'debug' is not defined
6ce2879 scripts/oe-pkgdata-util: add ability to find a recipe from a target package
948a714 scripts/oe-pkgdata-util: add ability to look up runtime package names
48755f1 scripts/oe-pkgdata-util: add ability to search for a target path
4ec1f8c scripts/oe-pkgdata-util: check path arguments to ensure they exist
8b42409 scripts/oe-pkgdata-util: improve help text and command line parsing
9ce903b scripts/oe-pkgdata-util: remove remnants of former pkgdata structure

It is because I backported this commit: (I'm sorry about that)

commit e58a1499accd74d3e6fe4f899711d4c680ebc18f
Author: Hongxu Jia <hongxu.jia@windriver.com>
Date:   Wed Nov 20 18:35:39 2013 +0800

     license.bbclass: fix copying license directories failed

It is used for fixing this bug:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=5572

Enalbe COPY_LIC_MANIFEST and COPY_LIC_DIRS: No kernel license is installed in image

But it used the "oe-pkgdata-util lookup-recipe" which is only on master branch,
I think that we'd better:

1) Revert this commit, then it works with minor problems.

Or

2) Fix the "oe-pkgdata-util lookup-recipe" on dora.

// Robert

> Cheers,
> Paul
>
>
> On Tuesday 11 March 2014 17:16:05 Hongxu Jia wrote:
>> It seems dora has some patches of oe-pkgdata-util not
>> rebased from poky, such as:
>>
>> commit 6ce287937e86a43d696e3615aa18d439928b7691
>> Author: Paul Eggleton <paul.eggleton@linux.intel.com>
>> Date:   Fri Oct 18 14:52:10 2013 +0100
>>
>>       scripts/oe-pkgdata-util: add ability to find a recipe from a target
>> package
>>
>> //Hongxu
>>
>> On 03/11/2014 04:48 PM, Jussi Laako wrote:
>>> Hi,
>>>
>>> Your recent (from November) change to license.bbclass in Yocto Dora
>>> release completely breaks COPY_LIC_DIRS.
>>>
>>> Running the command manually for any package results in command line
>>> syntax error:
>>> jussi@porkkala:/home/scratch/jussi/poky/build> oe-pkgdata-util
>>> lookup-recipe
>>> /home/scratch/jussi/poky/build/tmp/sysroots/cubox-i/pkgdata
>>> alsa-conf-base
>>> syntax: oe-pkgdata-util glob [-d] <pkgdatadir> <vendor-os> <pkglist>
>>> "<globs>"
>>>
>>>                       read-value [-d] <pkgdatadir> <vendor-os>
>>>
>>> <value-name> "<package-name>_<package_architecture>"
>>>
>>>
>>> Best regards,
>>>
>>>      - Jussi
>


  reply	other threads:[~2014-03-11 10:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <531ECDCE.3020805@sonarnerd.net>
2014-03-11  9:16 ` [dora]Re: Failure in license.bbclass Hongxu Jia
2014-03-11 10:02   ` Paul Eggleton
2014-03-11 10:40     ` Robert Yang [this message]
     [not found]       ` <532173C2.2000606@sonarnerd.net>
2014-03-25  9:09         ` Robert Yang
2014-03-25 13:43           ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=531EE822.7070201@windriver.com \
    --to=liezhi.yang@windriver.com \
    --cc=jussi@sonarnerd.net \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=paul.eggleton@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.