Re: [Qemu-devel] [PATCH V3 0/2] tests: Fix possible deadlock in qtest initialization

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1035 bytes --]

On 03/11/2014 06:24 AM, Marcel Apfelbaum wrote:
> V2 -> V3:
>      Addressed Eric Blake's review:
>      - Corrected a typo.
>      - Replace the commented Makefile part
> 
> V1 -> V2:
>     Addressed Stefan Hajnoczi's review:
>     - Dropped qtest_state_valid API
>     - Moved socket options in socket_accept. 
> 
> 'socket_accept' waits for Qemu to initialize its unix socket.
> If Qemu encounters an error during command line parsing,
> it can exit before initializing the communication channel.
> 
> Using a timeout for sockets fixes the issue, but is not
> enough. We need to know which test from check-qtest-*
> fails.
> 
> We tweak the Makefile to produce per-test output.
> The effect is that the output will grow, but we will know
> which qtest failed. This helps when an assert is made on
> other code and not in the test itself.
> 

Series:
Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]