[PATCH] tools/xcutils: Free xlt loggers after use

[PATCH] tools/xcutils: Free xlt loggers after use

[Andrew Cooper]

While not much of a functional change, this prevents irritating warnings from
valgrind when trying to analyse xc_domain_{save,restore}() themselves.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Ian Campbell <Ian.Campbell@citrix.com>
CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
 tools/xcutils/xc_restore.c |    1 +
 tools/xcutils/xc_save.c    |    1 +
 2 files changed, 2 insertions(+)

diff --git a/tools/xcutils/xc_restore.c b/tools/xcutils/xc_restore.c
index 4ea261b..616bd42 100644
--- a/tools/xcutils/xc_restore.c
+++ b/tools/xcutils/xc_restore.c
@@ -67,6 +67,7 @@ main(int argc, char **argv)
     }
 
     xc_interface_close(xch);
+    xtl_logger_destroy(l);
 
     return ret;
 }
diff --git a/tools/xcutils/xc_save.c b/tools/xcutils/xc_save.c
index e34bd2c..45ad0ce 100644
--- a/tools/xcutils/xc_save.c
+++ b/tools/xcutils/xc_save.c
@@ -222,6 +222,7 @@ main(int argc, char **argv)
         xc_evtchn_close(si.xce);
 
     xc_interface_close(si.xch);
+    xtl_logger_destroy(l);
 
     return ret;
 }
-- 
1.7.10.4

Re: [PATCH] tools/xcutils: Free xlt loggers after use

[Ian Jackson]

Andrew Cooper writes ("[PATCH] tools/xcutils: Free xlt loggers after use"):
> While not much of a functional change, this prevents irritating warnings from
> valgrind when trying to analyse xc_domain_{save,restore}() themselves.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Ian Campbell <Ian.Campbell@citrix.com>

Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>

(and fixed the subject line typo in the actual commit)

Ian.

Re: [PATCH] tools/xcutils: Free xlt loggers after use

[Andrew Cooper]

On 10/03/14 17:19, Ian Jackson wrote:
> Andrew Cooper writes ("[PATCH] tools/xcutils: Free xlt loggers after use"):
>> While not much of a functional change, this prevents irritating warnings from
>> valgrind when trying to analyse xc_domain_{save,restore}() themselves.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> CC: Ian Campbell <Ian.Campbell@citrix.com>
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
> Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>
>
> (and fixed the subject line typo in the actual commit)
>
> Ian.

Ah thanks - I hadn't noticed the typo.

That must be record timing from writing the patch to getting committed -
about 15 mins :)

~Andrew

Re: [PATCH] tools/xcutils: Free xlt loggers after use

[Ian Campbell]

On Mon, 2014-03-10 at 17:06 +0000, Andrew Cooper wrote:
> While not much of a functional change, this prevents irritating warnings from
> valgrind when trying to analyse xc_domain_{save,restore}() themselves.

Are you trying to valgrind xend or something? (I thought these were
exclusively used by xend).
>  tools/xcutils/xc_restore.c |    1 +
>  tools/xcutils/xc_save.c    |    1 +
>  2 files changed, 2 insertions(+)

Ian.

Re: [PATCH] tools/xcutils: Free xlt loggers after use

[Andrew Cooper]

On 11/03/14 13:25, Ian Campbell wrote:
> On Mon, 2014-03-10 at 17:06 +0000, Andrew Cooper wrote:
>> While not much of a functional change, this prevents irritating warnings from
>> valgrind when trying to analyse xc_domain_{save,restore}() themselves.
> Are you trying to valgrind xend or something? (I thought these were
> exclusively used by xend).
>>  tools/xcutils/xc_restore.c |    1 +
>>  tools/xcutils/xc_save.c    |    1 +
>>  2 files changed, 2 insertions(+)
> Ian.
>
>

I am developing the migration stream v2, and using xc_save/restore as
thin wrappers around xc_domain_save/restore(), where I can dump the
intermediate stream to a file and verify it for correctness.

~Andrew

Re: [PATCH] tools/xcutils: Free xlt loggers after use

[Ian Campbell]

On Tue, 2014-03-11 at 13:51 +0000, Andrew Cooper wrote:
> On 11/03/14 13:25, Ian Campbell wrote:
> > On Mon, 2014-03-10 at 17:06 +0000, Andrew Cooper wrote:
> >> While not much of a functional change, this prevents irritating warnings from
> >> valgrind when trying to analyse xc_domain_{save,restore}() themselves.
> > Are you trying to valgrind xend or something? (I thought these were
> > exclusively used by xend).
> >>  tools/xcutils/xc_restore.c |    1 +
> >>  tools/xcutils/xc_save.c    |    1 +
> >>  2 files changed, 2 insertions(+)
> > Ian.
> >
> >
> 
> I am developing the migration stream v2, and using xc_save/restore as
> thin wrappers around xc_domain_save/restore(), where I can dump the
> intermediate stream to a file and verify it for correctness.

Ah, useful!

I suspect you could also achieve this by providing xl migrate with a
custom -s command which involved a tee as well as a ssh, but you may as
well stick with what you've got.

Ian.