From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH] tools/xcutils: Free xlt loggers after use Date: Tue, 11 Mar 2014 13:51:24 +0000 Message-ID: <531F14DC.4090008@citrix.com> References: <1394471176-14388-1-git-send-email-andrew.cooper3@citrix.com> <1394544317.18366.69.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1394544317.18366.69.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Ian Jackson , Xen-devel List-Id: xen-devel@lists.xenproject.org On 11/03/14 13:25, Ian Campbell wrote: > On Mon, 2014-03-10 at 17:06 +0000, Andrew Cooper wrote: >> While not much of a functional change, this prevents irritating warnings from >> valgrind when trying to analyse xc_domain_{save,restore}() themselves. > Are you trying to valgrind xend or something? (I thought these were > exclusively used by xend). >> tools/xcutils/xc_restore.c | 1 + >> tools/xcutils/xc_save.c | 1 + >> 2 files changed, 2 insertions(+) > Ian. > > I am developing the migration stream v2, and using xc_save/restore as thin wrappers around xc_domain_save/restore(), where I can dump the intermediate stream to a file and verify it for correctness. ~Andrew