From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40879) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNOWP-0001SM-Bv for qemu-devel@nongnu.org; Tue, 11 Mar 2014 11:23:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNOWK-0008Ac-4G for qemu-devel@nongnu.org; Tue, 11 Mar 2014 11:23:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11598) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNOWJ-0008AK-SF for qemu-devel@nongnu.org; Tue, 11 Mar 2014 11:23:08 -0400 Message-ID: <531F2A4E.7080508@redhat.com> Date: Tue, 11 Mar 2014 09:22:54 -0600 From: Eric Blake MIME-Version: 1.0 References: <1394304438-14848-1-git-send-email-l@dorileo.org> <20140311110616.GD3215@dhcp-200-207.str.redhat.com> <20140311140918.GA30837@dorilex> In-Reply-To: <20140311140918.GA30837@dorilex> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Rj9Xx68t9Rw83LePfQptXKNg4jGR05PNe" Subject: Re: [Qemu-devel] [PATCH RFC 0/2] qemu-arg: general purpose argument parser List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Leandro Dorileo , Kevin Wolf Cc: Peter Lieven , Peter Maydell , Fam Zheng , Stefan Weil , Michael Tokarev , qemu-devel@nongnu.org, Stefan Hajnoczi , Paolo Bonzini , Laszlo Ersek This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Rj9Xx68t9Rw83LePfQptXKNg4jGR05PNe Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/11/2014 08:09 AM, Leandro Dorileo wrote: > Hi Kevin, >=20 > On Tue, Mar 11, 2014 at 12:06:16PM +0100, Kevin Wolf wrote: >> Am 08.03.2014 um 19:47 hat Leandro Dorileo geschrieben: >>> The following patchset introduces a general purpose argument parser a= nd migrates >>> qemu-img to make use of it. qemu-img is just the first user of it, if= we see a >>> good feedback here I move forward and migrate all the other possible = users. >> >> I was planning to reply to this in more detail, but it doesn't look li= ke >> I can find the time to do so, so let me just summarise my thoughts >> briefly. >=20 > Ok. >=20 >> >> I do like the idea of simplifying qemu-img's argument parsing, but we >> shouldn't make the mistake of introducing another option parsing >> infrastructure and end up with three different coexisting models. If w= e >> were to introduce a new framework, we must make sure that all code is >> converted to it and QemuOpts can be dropped. >=20 > Agreed. For that matter, if you want to help the current conversion efforts going on, we are trying to get rid of QEMUOptionParameters to _just_ use QemuOpts: https://lists.gnu.org/archive/html/qemu-devel/2014-03/msg01728.html >> >> We would probably need to add a new parser to QemuOpts that parses >> command line options into a QemuOpts, and extend the definition of the= m >> with a couple of new features that are required there (sub-QemuOpts fo= r >> -o, perhaps enumerations for things like --output=3Dhuman/json, positi= onal >> parameters). >=20 > Ok. We also need to think how to expose those improvements via the QMP command query-command-line-arguments; lots of details in this thread: https://lists.gnu.org/archive/html/qemu-devel/2014-03/threads.html#00934 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Rj9Xx68t9Rw83LePfQptXKNg4jGR05PNe Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTHypOAAoJEKeha0olJ0NqodEIAIQH5TceDL2Vc9NJXI/Sbucu NOAhviYVKg3CEEw/90wsO0Caznp2KkIqE0YtQduM3q/IwnZFQRbOHG6zKzugbXVv bic8wmEUKm79RPXgHLwmBxIrVag0tx23VSsVVsPu+ClYmm7IzfVbD3GBMI1BvC0n UlOxVV3mpO14gDVD/gemXvLAeymT7vRO6ZNvQE0lvjfV5d5DCWRnH6uBeSMmekVL rfoUiOr6590jZWDt2NczofcZwhgDpx9HC/5Hi/v446j372XSJGYCQYkIGY0DD2E3 2pJhAITFUnu362IuAgvbiJBhS5vItdlESLiYWP/1TXn9HzJduTTGvPNNK6Wrcx0= =fHCp -----END PGP SIGNATURE----- --Rj9Xx68t9Rw83LePfQptXKNg4jGR05PNe--