From: Eric Blake <eblake@redhat.com>
To: Marcel Apfelbaum <marcel.a@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, ehabkost@redhat.com, mst@redhat.com,
stefanha@redhat.com, armbru@redhat.com, aliguori@amazon.com,
pbonzini@redhat.com, lersek@redhat.com, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH 2/3] hw/null-machine: Convert null machine to QOM
Date: Tue, 11 Mar 2014 09:47:20 -0600 [thread overview]
Message-ID: <531F3008.6020208@redhat.com> (raw)
In-Reply-To: <1394552156-18901-3-git-send-email-marcel.a@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 601 bytes --]
On 03/11/2014 09:35 AM, Marcel Apfelbaum wrote:
> Needed by some tests.
>
> Signed-off-by: Marcel Apfelbaum <marcel.a@redhat.com>
> ---
> hw/core/null-machine.c | 13 +++++++++----
> 1 file changed, 9 insertions(+), 4 deletions(-)
>
> -static void register_machines(void)
> +static const TypeInfo none_machine_type_info = {
> + .name = "none-machine",
> + .parent = TYPE_MACHINE,
> + .class_data = (void *)&machine_none
Why do you need a cast to (void*) in C?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2014-03-11 15:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 15:35 [Qemu-devel] [PATCH 0/3] tests/qdev-global-props: fixes due to machine conversion to QOM Marcel Apfelbaum
2014-03-11 15:35 ` [Qemu-devel] [PATCH 1/3] hw/machine: move QEMUMachine assignment into the core machine Marcel Apfelbaum
2014-03-11 15:53 ` Marcel Apfelbaum
2014-03-11 15:35 ` [Qemu-devel] [PATCH 2/3] hw/null-machine: Convert null machine to QOM Marcel Apfelbaum
2014-03-11 15:47 ` Eric Blake [this message]
2014-03-11 15:50 ` Marcel Apfelbaum
2014-03-11 15:35 ` [Qemu-devel] [PATCH 3/3] tests/qdev-global-props: Manually add an instance of a QOM machine Marcel Apfelbaum
2014-03-11 17:11 ` [Qemu-devel] [PATCH 0/3] tests/qdev-global-props: fixes due to machine conversion to QOM Andreas Färber
2014-03-11 19:44 ` Marcel Apfelbaum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531F3008.6020208@redhat.com \
--to=eblake@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@amazon.com \
--cc=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kwolf@redhat.com \
--cc=lersek@redhat.com \
--cc=marcel.a@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.