From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Subject: Re: [PATCH v5 6/8] ARM: dts: sun4i: Add support for mmc Date: Tue, 11 Mar 2014 16:55:47 +0100 Message-ID: <531F3203.3010807@redhat.com> References: <20140211190543.4568.83517.stgit@dizzy-6.o2s.ch> <20140211193423.4568.34947.stgit@dizzy-6.o2s.ch> Reply-To: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: List-Post: , List-Help: , List-Archive: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Subscribe: , List-Unsubscribe: , To: mr.nuke.me-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ulf Hansson , Laurent Pinchart , Mike Turquette , Simon Baatz , =?UTF-8?B?RW1pbGlvIEzDs3Bleg==?= , linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Chris Ball , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, H Hartley Sweeten , Tejun Heo , Maxime Ripard , Guennadi Liakhovetski , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, david.lanzendoerfer-Z7Kmv9EsliU@public.gmane.org List-Id: linux-mmc@vger.kernel.org Hi, Oh, good catch, thanks! Fixed in the sunxi-devel branch in my *personal* git repo. I'll also push this to the official linux-sunxi sunxi-devel branch later today. Regards, Hans On 03/10/2014 10:49 PM, mr.nuke.me-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote: > On Tuesday, February 11, 2014 1:34:25 PM UTC-6, David Lanzend=C3=B6rfer w= rote: >> diff --git a/arch/arm/boot/dts/sun4i-a10-cubieboard.dts >> b/arch/arm/boot/dts/sun4i-a10-cubieboard.dts >> index b139ee6..20b976a 100644 >> --- a/arch/arm/boot/dts/sun4i-a10-cubieboard.dts >> +++ b/arch/arm/boot/dts/sun4i-a10-cubieboard.dts >> @@ -33,6 +33,14 @@ >> }; >> =09 >> }; >> + mmc0: mmc@01c0f000 { >> + pinctrl-names =3D "default", "default"; >> + pinctrl-0 =3D <&mmc0_pins_a>; >> + pinctrl-1 =3D <&mmc0_cd_pin_reference_design>; >> + cd-gpios =3D <&pio 7 1 0>; /* PH1 */ >> + status =3D "okay"; >> + }; >> + >> pinctrl@01c20800 { >> =09 >> led_pins_cubieboard: led_pins@0 { >> =09 >> allwinner,pins =3D "PH20", "PH21"; >> diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi >> b/arch/arm/boot/dts/sun4i-a10.dtsi >> index 9044c53..d040d37 100644 >> --- a/arch/arm/boot/dts/sun4i-a10.dtsi >> +++ b/arch/arm/boot/dts/sun4i-a10.dtsi >> @@ -330,6 +330,46 @@ >> #size-cells =3D <0>; >> =09 >> }; >> + mmc0: mmc@01c0f000 { >> + compatible =3D "allwinner,sun5i-a13-mmc"; >=20 > Should be "allwinner,sun4i-a10-mmc", or we will hang the MMC driver on A1= 0. >=20 >> + mmc1: mmc@01c10000 { >> + compatible =3D "allwinner,sun5i-a13-mmc"; > ditto >=20 >> + mmc2: mmc@01c11000 { >> + compatible =3D "allwinner,sun5i-a13-mmc"; > ditto >=20 >> + mmc3: mmc@01c12000 { >> + compatible =3D "allwinner,sun5i-a13-mmc"; > ditto >=20 --=20 You received this message because you are subscribed to the Google Groups "= linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 From: hdegoede@redhat.com (Hans de Goede) Date: Tue, 11 Mar 2014 16:55:47 +0100 Subject: [PATCH v5 6/8] ARM: dts: sun4i: Add support for mmc In-Reply-To: References: <20140211190543.4568.83517.stgit@dizzy-6.o2s.ch> <20140211193423.4568.34947.stgit@dizzy-6.o2s.ch> Message-ID: <531F3203.3010807@redhat.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, Oh, good catch, thanks! Fixed in the sunxi-devel branch in my *personal* git repo. I'll also push this to the official linux-sunxi sunxi-devel branch later today. Regards, Hans On 03/10/2014 10:49 PM, mr.nuke.me at gmail.com wrote: > On Tuesday, February 11, 2014 1:34:25 PM UTC-6, David Lanzend?rfer wrote: >> diff --git a/arch/arm/boot/dts/sun4i-a10-cubieboard.dts >> b/arch/arm/boot/dts/sun4i-a10-cubieboard.dts >> index b139ee6..20b976a 100644 >> --- a/arch/arm/boot/dts/sun4i-a10-cubieboard.dts >> +++ b/arch/arm/boot/dts/sun4i-a10-cubieboard.dts >> @@ -33,6 +33,14 @@ >> }; >> >> }; >> + mmc0: mmc at 01c0f000 { >> + pinctrl-names = "default", "default"; >> + pinctrl-0 = <&mmc0_pins_a>; >> + pinctrl-1 = <&mmc0_cd_pin_reference_design>; >> + cd-gpios = <&pio 7 1 0>; /* PH1 */ >> + status = "okay"; >> + }; >> + >> pinctrl at 01c20800 { >> >> led_pins_cubieboard: led_pins at 0 { >> >> allwinner,pins = "PH20", "PH21"; >> diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi >> b/arch/arm/boot/dts/sun4i-a10.dtsi >> index 9044c53..d040d37 100644 >> --- a/arch/arm/boot/dts/sun4i-a10.dtsi >> +++ b/arch/arm/boot/dts/sun4i-a10.dtsi >> @@ -330,6 +330,46 @@ >> #size-cells = <0>; >> >> }; >> + mmc0: mmc at 01c0f000 { >> + compatible = "allwinner,sun5i-a13-mmc"; > > Should be "allwinner,sun4i-a10-mmc", or we will hang the MMC driver on A10. > >> + mmc1: mmc at 01c10000 { >> + compatible = "allwinner,sun5i-a13-mmc"; > ditto > >> + mmc2: mmc at 01c11000 { >> + compatible = "allwinner,sun5i-a13-mmc"; > ditto > >> + mmc3: mmc at 01c12000 { >> + compatible = "allwinner,sun5i-a13-mmc"; > ditto > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754366AbaCKP4i (ORCPT ); Tue, 11 Mar 2014 11:56:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55549 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752907AbaCKP4f (ORCPT ); Tue, 11 Mar 2014 11:56:35 -0400 Message-ID: <531F3203.3010807@redhat.com> Date: Tue, 11 Mar 2014 16:55:47 +0100 From: Hans de Goede User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: mr.nuke.me@gmail.com, linux-sunxi@googlegroups.com CC: devicetree@vger.kernel.org, Ulf Hansson , Laurent Pinchart , Mike Turquette , Simon Baatz , =?UTF-8?B?RW1pbGlvIEzDs3Bleg==?= , linux-mmc@vger.kernel.org, Chris Ball , linux-kernel@vger.kernel.org, H Hartley Sweeten , Tejun Heo , Maxime Ripard , Guennadi Liakhovetski , linux-arm-kernel@lists.infradead.org, david.lanzendoerfer@o2s.ch Subject: Re: [PATCH v5 6/8] ARM: dts: sun4i: Add support for mmc References: <20140211190543.4568.83517.stgit@dizzy-6.o2s.ch> <20140211193423.4568.34947.stgit@dizzy-6.o2s.ch> In-Reply-To: X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Oh, good catch, thanks! Fixed in the sunxi-devel branch in my *personal* git repo. I'll also push this to the official linux-sunxi sunxi-devel branch later today. Regards, Hans On 03/10/2014 10:49 PM, mr.nuke.me@gmail.com wrote: > On Tuesday, February 11, 2014 1:34:25 PM UTC-6, David Lanzendörfer wrote: >> diff --git a/arch/arm/boot/dts/sun4i-a10-cubieboard.dts >> b/arch/arm/boot/dts/sun4i-a10-cubieboard.dts >> index b139ee6..20b976a 100644 >> --- a/arch/arm/boot/dts/sun4i-a10-cubieboard.dts >> +++ b/arch/arm/boot/dts/sun4i-a10-cubieboard.dts >> @@ -33,6 +33,14 @@ >> }; >> >> }; >> + mmc0: mmc@01c0f000 { >> + pinctrl-names = "default", "default"; >> + pinctrl-0 = <&mmc0_pins_a>; >> + pinctrl-1 = <&mmc0_cd_pin_reference_design>; >> + cd-gpios = <&pio 7 1 0>; /* PH1 */ >> + status = "okay"; >> + }; >> + >> pinctrl@01c20800 { >> >> led_pins_cubieboard: led_pins@0 { >> >> allwinner,pins = "PH20", "PH21"; >> diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi >> b/arch/arm/boot/dts/sun4i-a10.dtsi >> index 9044c53..d040d37 100644 >> --- a/arch/arm/boot/dts/sun4i-a10.dtsi >> +++ b/arch/arm/boot/dts/sun4i-a10.dtsi >> @@ -330,6 +330,46 @@ >> #size-cells = <0>; >> >> }; >> + mmc0: mmc@01c0f000 { >> + compatible = "allwinner,sun5i-a13-mmc"; > > Should be "allwinner,sun4i-a10-mmc", or we will hang the MMC driver on A10. > >> + mmc1: mmc@01c10000 { >> + compatible = "allwinner,sun5i-a13-mmc"; > ditto > >> + mmc2: mmc@01c11000 { >> + compatible = "allwinner,sun5i-a13-mmc"; > ditto > >> + mmc3: mmc@01c12000 { >> + compatible = "allwinner,sun5i-a13-mmc"; > ditto >