Re: [PATCH/RFC] git-gui: Add a 'recursive' checkbox in the clone menu.

[Jens Lehmann <Jens.Lehmann@web.de>]

Am 11.03.2014 12:07, schrieb Henri GEIST:
> Le mercredi 05 mars 2014 à 19:00 +0100, Jens Lehmann a écrit :
>> Am 05.03.2014 00:01, schrieb Henri GEIST:
>>> Permit to do a 'git clone --recursive' through git-gui.
>>
>> I really like where this is heading!
>>
>> Some minor issues:
>>
>> - I think we should be more verbose in the commit message,
>>   including that and why the default should be "on". Maybe
>>   like this?
>>
>>   "Permit to do a 'git clone --recursive' through git-gui.
>>   Add a 'recursive' checkbox in the clone menu which allows
>>   users to clone a repository and all its submodules in one
>>   go (unless the 'update' flag is set to "none" in the
>>   .gitmodules file for a submodule, in that case that
>>   specific submodule is not cloned automatically).
>>
>>   Enable this new option per default, as most users want to
>>   clone all submodules too when cloning the superproject
>>   (This is currently not possible without leaving git gui
>>   or adding a custom tool entry for that)."
>>
>>
>> - I'd rather change the button text from "Recursive (For
>>   submodules)" to something like "Recursively clone
>>   submodules too" or such.
>>
>>
> 
> Perfect.
> Would you like me to send the new version of the patch in this thread
> Or to make a new thread [patch v2] ?

It doesn't matter that much as long as you start the subject with
"[PATCH v2]". But I believe you should send it to Pat and create
the diff from inside the git-gui directory so he can simply apply
it to his repository.