From: Steve Dickson <SteveD@redhat.com>
To: Aaro Koskinen <aaro.koskinen@iki.fi>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH nfs-utils] tools: use install -m instead of --mode
Date: Tue, 11 Mar 2014 14:08:29 -0400 [thread overview]
Message-ID: <531F511D.1000009@RedHat.com> (raw)
In-Reply-To: <1393621584-15467-1-git-send-email-aaro.koskinen@iki.fi>
On 02/28/2014 04:06 PM, Aaro Koskinen wrote:
> Use install -m instead of--mode for better compatibility.
> E.g. busybox's install doesn't support the long option.
>
> Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Committed...
steved.
> ---
> tools/mountstats/Makefile.am | 2 +-
> tools/nfs-iostat/Makefile.am | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/mountstats/Makefile.am b/tools/mountstats/Makefile.am
> index ca617a2..c2e9f99 100644
> --- a/tools/mountstats/Makefile.am
> +++ b/tools/mountstats/Makefile.am
> @@ -8,6 +8,6 @@ EXTRA_DIST = $(man8_MANS) $(PYTHON_FILES)
> all-local: $(PYTHON_FILES)
>
> install-data-hook:
> - $(INSTALL) --mode 755 mountstats.py $(DESTDIR)$(sbindir)/mountstats
> + $(INSTALL) -m 755 mountstats.py $(DESTDIR)$(sbindir)/mountstats
>
> MAINTAINERCLEANFILES=Makefile.in
> diff --git a/tools/nfs-iostat/Makefile.am b/tools/nfs-iostat/Makefile.am
> index 30f4054..3ae0f29 100644
> --- a/tools/nfs-iostat/Makefile.am
> +++ b/tools/nfs-iostat/Makefile.am
> @@ -8,6 +8,6 @@ EXTRA_DIST = $(man8_MANS) $(PYTHON_FILES)
> all-local: $(PYTHON_FILES)
>
> install-data-hook:
> - $(INSTALL) --mode 755 nfs-iostat.py $(DESTDIR)$(sbindir)/nfsiostat
> + $(INSTALL) -m 755 nfs-iostat.py $(DESTDIR)$(sbindir)/nfsiostat
>
> MAINTAINERCLEANFILES=Makefile.in
>
prev parent reply other threads:[~2014-03-11 19:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 21:06 [PATCH nfs-utils] tools: use install -m instead of --mode Aaro Koskinen
2014-03-11 18:08 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531F511D.1000009@RedHat.com \
--to=steved@redhat.com \
--cc=aaro.koskinen@iki.fi \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.