From: "H. Peter Anvin" <hpa@zytor.com>
To: Andy Lutomirski <luto@amacapital.net>,
Linus Torvalds <torvalds@linux-foundation.org>,
x86@kernel.org
Cc: Stefani Seibold <stefani@seibold.net>,
Andreas Brief <Andreas.Brief@rohde-schwarz.com>,
Martin Runge <Martin.Runge@rohde-schwarz.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Dave Jones <davej@redhat.com>, Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH] x86: Dynamically relocate the compat vdso
Date: Tue, 11 Mar 2014 14:44:52 -0700 [thread overview]
Message-ID: <531F83D4.1000500@zytor.com> (raw)
In-Reply-To: <7708c7e74155af17548b3737de81495888685760.1394573523.git.luto@amacapital.net>
On 03/11/2014 02:33 PM, Andy Lutomirski wrote:
> diff --git a/arch/x86/include/asm/pgtable_types.h b/arch/x86/include/asm/pgtable_types.h
> index 1aa9ccd..943f166 100644
> --- a/arch/x86/include/asm/pgtable_types.h
> +++ b/arch/x86/include/asm/pgtable_types.h
> @@ -214,13 +214,8 @@
> #ifdef CONFIG_X86_64
> #define __PAGE_KERNEL_IDENT_LARGE_EXEC __PAGE_KERNEL_LARGE_EXEC
> #else
> -/*
> - * For PDE_IDENT_ATTR include USER bit. As the PDE and PTE protection
> - * bits are combined, this will alow user to access the high address mapped
> - * VDSO in the presence of CONFIG_COMPAT_VDSO
> - */
> #define PTE_IDENT_ATTR 0x003 /* PRESENT+RW */
> -#define PDE_IDENT_ATTR 0x067 /* PRESENT+RW+USER+DIRTY+ACCESSED */
> +#define PDE_IDENT_ATTR 0x063 /* PRESENT+RW+USER+DIRTY+ACCESSED */
> #define PGD_IDENT_ATTR 0x001 /* PRESENT (no other attributes) */
> #endif
>
Please make this hunk a separate patch for bisecting reasons.
-hpa
prev parent reply other threads:[~2014-03-11 21:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 21:33 [PATCH] x86: Dynamically relocate the compat vdso Andy Lutomirski
2014-03-11 21:44 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531F83D4.1000500@zytor.com \
--to=hpa@zytor.com \
--cc=Andreas.Brief@rohde-schwarz.com \
--cc=Martin.Runge@rohde-schwarz.com \
--cc=andi@firstfloor.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=stefani@seibold.net \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.